From 9886674f74b40ffb8c34396b6c2b01349ebc0175 Mon Sep 17 00:00:00 2001
From: Mark Stacey <markjstacey@gmail.com>
Date: Fri, 18 Oct 2024 16:02:11 -0230
Subject: [PATCH] chore: Remove obsolete preview build support

We had previously configured CI to support installing `@metamask`-
scoped packages from the GitHub npm registry, as we used this registry
for "preview builds" from the core repository in the past. This is no
longer used; we publish preview builds to npm now instead. The obsolete
CI changes have been removed.

* [Preview build instructions](https://github.com/MetaMask/core/blob/main/docs/contributing.md#testing-changes-to-packages-with-preview-builds) ([permalink](https://github.com/MetaMask/core/blob/56efd1d13a8873a5abb9bd9880d0576148b9d1e4/docs/contributing.md#testing-changes-to-packages-with-preview-builds))
* Preview build related extension PRs: #16547, #19970, #20096, #20312
---
 .circleci/config.yml                      |  2 +-
 .circleci/scripts/install-dependencies.sh | 42 -----------------------
 .yarnrc.yml                               |  9 -----
 3 files changed, 1 insertion(+), 52 deletions(-)
 delete mode 100755 .circleci/scripts/install-dependencies.sh

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 74815818582f..af3f683a9d69 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -477,7 +477,7 @@ jobs:
       - gh/install
       - run:
           name: Install dependencies
-          command: .circleci/scripts/install-dependencies.sh
+          command: yarn --immutable
       - save_cache:
           key: dependency-cache-{{ checksum "/tmp/YARN_VERSION" }}-{{ checksum "yarn.lock" }}
           paths:
diff --git a/.circleci/scripts/install-dependencies.sh b/.circleci/scripts/install-dependencies.sh
deleted file mode 100755
index 35b7a690fa0c..000000000000
--- a/.circleci/scripts/install-dependencies.sh
+++ /dev/null
@@ -1,42 +0,0 @@
-#!/usr/bin/env bash
-
-set -e
-set -o pipefail
-
-IS_NON_FORK_DRAFT='false'
-
-if [[ -n $CIRCLE_PULL_REQUEST ]] && gh auth status
-then
-  PR_NUMBER="${CIRCLE_PULL_REQUEST##*/}"
-  if [ -n "$PR_NUMBER" ]
-  then
-    IS_NON_FORK_DRAFT="$(gh pr view --json isDraft --jq '.isDraft' "$PR_NUMBER")"
-  fi
-fi
-
-# Build query to see whether there are any "preview-like" packages in the manifest
-# A "preview-like" package is a `@metamask`-scoped package with a prerelease version that has no period.
-QUERY='.dependencies + .devDependencies'                            # Get list of all dependencies
-QUERY+=' | with_entries( select(.key | startswith("@metamask") ) )' # filter to @metamask-scoped packages
-QUERY+=' | to_entries[].value'                                      # Get version ranges
-QUERY+=' | select(test("^\\d+\\.\\d+\\.\\d+-[^.]+$"))'              # Get pinned versions where the prerelease part has no "."
-
-# Use `-e` flag so that exit code indicates whether any matches were found
-if jq -e "${QUERY}" < ./package.json
-then
-  echo "Preview builds detected"
-  HAS_PREVIEW_BUILDS='true'
-else
-  echo "No preview builds detected"
-  HAS_PREVIEW_BUILDS='false'
-fi
-
-if [[ $IS_NON_FORK_DRAFT == 'true' && $HAS_PREVIEW_BUILDS == 'true' ]]
-then
-  # Use GitHub registry on draft PRs, allowing the use of preview builds
-  echo "Installing with preview builds"
-  METAMASK_NPM_REGISTRY=https://npm.pkg.github.com yarn --immutable
-else
-  echo "Installing without preview builds"
-  yarn --immutable
-fi
diff --git a/.yarnrc.yml b/.yarnrc.yml
index f4d8fc7fa471..d6d660bc73f2 100644
--- a/.yarnrc.yml
+++ b/.yarnrc.yml
@@ -118,15 +118,6 @@ npmAuditIgnoreAdvisories:
   # Maintenance has stopped and the project will be archived in 2025.
   - 'react-beautiful-dnd (deprecation)'
 
-npmRegistries:
-  'https://npm.pkg.github.com':
-    npmAlwaysAuth: true
-    npmAuthToken: '${GITHUB_PACKAGE_READ_TOKEN-}'
-
-npmScopes:
-  metamask:
-    npmRegistryServer: '${METAMASK_NPM_REGISTRY:-https://registry.yarnpkg.com}'
-
 plugins:
   - path: .yarn/plugins/@yarnpkg/plugin-allow-scripts.cjs
     spec: 'https://raw.githubusercontent.com/LavaMoat/LavaMoat/main/packages/yarn-plugin-allow-scripts/bundles/@yarnpkg/plugin-allow-scripts.js'