Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): gridplus-sdk@2.5.1->~2.6.0 #27973

Merged
merged 7 commits into from
Oct 22, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 18, 2024

Description

  • fix(deps): gridplus-sdk@2.5.1->~2.6.0
    • 2.7.0 updates to @ethereumjs/tx 5, so holding at 2.6
    • removes dependency on legacy ethereum-cryptography v1
  • dedupe and unpin @ethereumjs/tx to ^4.2.0
    • eth-lattice-keyring is pinned to @ethereumjs/tx@4.1.1
    • gridplus-sdk is pinned to @ethereumjs/tx@4.1.2
  • fix(deps): bump elliptic@6.5.4->^6.5.7 via resolutions
  • fix(deps): bump secp256k

Open in GitHub Codespaces

Related issues

Resolves

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat marked this pull request as ready for review October 18, 2024 22:28
@legobeat legobeat requested review from a team as code owners October 18, 2024 22:28
@legobeat legobeat force-pushed the deps-gridplus-sdk branch 2 times, most recently from a7ae295 to 1968816 Compare October 21, 2024 17:01
- 2.7.0 updates to @ethereumjs/tx 5
- dedupe and unpin @ethereumjs/tx to ^4.2.0
  - eth-lattice-keyring is pinned to @ethereumjs/tx@4.1.1
  - gridplus-sdk is pinned to @ethereumjs/tx@4.1.2
NicholasEllul
NicholasEllul previously approved these changes Oct 21, 2024
Copy link
Contributor

@NicholasEllul NicholasEllul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legobeat

This comment was marked as outdated.

NicholasEllul

This comment was marked as outdated.

@legobeat legobeat requested a review from a team October 22, 2024 06:48
@hjetpoluru hjetpoluru added this pull request to the merge queue Oct 22, 2024
Merged via the queue into MetaMask:develop with commit 134d9a6 Oct 22, 2024
79 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants