Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated event name for site cell component #27981

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Oct 21, 2024

This PR is to update the event name for metametrics in site cell component

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3263

Manual testing steps

  1. Go to ui/contexts/metametrics.js
  2. In trackEvent in this file, add a log to see the payload
  3. Run extension with yarn start. Go to Permissions Page, click on edit button for accounts and networks and check the console to verify the payload.

Screenshots/Recordings

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested a review from a team as a code owner October 21, 2024 10:02
@NidhiKJha NidhiKJha added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Oct 21, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 21, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [26e448d]
Page Load Metrics (2012 ± 89 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint19523821929438210
domContentLoaded17302315198116780
load17412389201218589
domInteractive17103522412
backgroundConnect973302110
firstReactRender481951083015
getState566252311
initialActions01000
loadScripts12591728147314369
setupStore1081262110
uiStartup19442588224418287
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NidhiKJha NidhiKJha added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
@NidhiKJha NidhiKJha added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
@NidhiKJha NidhiKJha added this pull request to the merge queue Oct 22, 2024
Merged via the queue into develop with commit c926f96 Oct 22, 2024
87 checks passed
@NidhiKJha NidhiKJha deleted the metrics-update-connections branch October 22, 2024 13:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants