Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick: Disable account syncing prod in v12.5.0 #27982

Merged

Conversation

benjisclowder
Copy link
Contributor

@benjisclowder benjisclowder commented Oct 21, 2024

Cherry-picks #27943

Description

This PR disables account syncing in prod until we have e2e tests and documentation of proper testing.

There were no merge conflicts when picking these commits.

Open in GitHub Codespaces

Related issues

Fixes: #27943

Manual testing steps

  1. yarn build
  2. Account syncing should not occur

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**

This PR disables account syncing in prod until we have e2e tests and
documentation of proper testing

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27943?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. `yarn build`
2. Account syncing should not occur

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@benjisclowder benjisclowder added team-extension-platform team-notifications Notifications team release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Oct 21, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@benjisclowder benjisclowder marked this pull request as ready for review October 21, 2024 10:41
@benjisclowder benjisclowder requested a review from a team as a code owner October 21, 2024 10:41
@metamaskbot
Copy link
Collaborator

Builds ready [748113a]
Page Load Metrics (1751 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15542120174613866
domContentLoaded15192108172213967
load15512184175114771
domInteractive17241564522

@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2024
@matteoscurati matteoscurati reopened this Oct 21, 2024
@danjm danjm merged commit ab0250e into Version-v12.5.0 Oct 21, 2024
98 of 100 checks passed
@danjm danjm deleted the cherry-pick-12.5.0-disable-account-syncing-prod branch October 21, 2024 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-extension-platform team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants