Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removing warning prop from settings #27990

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

NiranjanaBinoy
Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy commented Oct 21, 2024

Description

Even though warning property is still used in the setting-tab and security-tab, we are no longer using displayWarning to update the error from the settings. This makes the error displayed in the tabs irrelevant to the component. So with this PR we are removing the warning property from settings-tab and security-tab.
We are removing the warning property from advance-tab in #26999

Open in GitHub Codespaces

Related issues

Related to #25838

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NiranjanaBinoy NiranjanaBinoy self-assigned this Oct 21, 2024
@NiranjanaBinoy NiranjanaBinoy requested a review from a team as a code owner October 21, 2024 15:24
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NiranjanaBinoy NiranjanaBinoy requested a review from a team October 21, 2024 15:25
@NiranjanaBinoy NiranjanaBinoy changed the title Removing warning prop from settings fix: Removing warning prop from settings Oct 21, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [0f80da0]
Page Load Metrics (1902 ± 137 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33524901801429206
domContentLoaded155224351872286137
load156324421902285137
domInteractive1798492211
backgroundConnect86431199
firstReactRender44133932411
getState54913126
initialActions01000
loadScripts113619081417251121
setupStore1076242110
uiStartup174926982097312150
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -294 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

2 participants