Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cherry-pick ENS resolution fix [this is a test - please ignore] #27995

Closed
wants to merge 3 commits into from

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Oct 21, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…edition) (#24496)

- Upgrade from obsolete `eth-rpc-errors` to `@metamask/rpc-errors`
  - This introduce handling of error causes

See [here](MetaMask/rpc-errors#140) for some
context.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24496?quickstart=1)

- #22871

- [x] MetaMask/rpc-errors#158
- [x] MetaMask/rpc-errors#144
  - [x] MetaMask/rpc-errors#140

- #22875

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
#22875)

- #27784
- MetaMask/eth-json-rpc-middleware#335
- #27917
- #18510
- #15250
- MetaMask/metamask-improvement-proposals#36

- [x] #24496

- #24496

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [x] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@Gudahtt Gudahtt changed the base branch from develop to master October 21, 2024 18:25
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Oct 21, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/generator@7.25.5 None 0 489 kB nicolo-ribaudo
npm/@babel/helper-create-class-features-plugin@7.25.4 None +2 613 kB nicolo-ribaudo
npm/@babel/helper-module-imports@7.24.7 None 0 63.7 kB nicolo-ribaudo
npm/@babel/helper-plugin-utils@7.24.8 None 0 114 kB nicolo-ribaudo
npm/@babel/helper-replace-supers@7.25.0 None 0 106 kB nicolo-ribaudo
npm/@babel/helper-simple-access@7.24.7 None 0 14.1 kB nicolo-ribaudo
npm/@babel/helper-skip-transparent-expression-wrappers@7.24.7 None 0 58.5 kB nicolo-ribaudo
npm/@babel/helper-validator-option@7.24.8 None 0 11.8 kB nicolo-ribaudo
npm/@babel/plugin-syntax-jsx@7.24.7 None 0 70 kB nicolo-ribaudo
npm/@babel/plugin-syntax-typescript@7.25.4 None 0 69.7 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/plugin-transform-modules-commonjs@7.24.8 None 0 107 kB nicolo-ribaudo
npm/@babel/plugin-transform-typescript@7.25.2 None 0 200 kB nicolo-ribaudo
npm/@babel/preset-typescript@7.24.7 None 0 90.8 kB nicolo-ribaudo
npm/@babel/runtime@7.25.4 None 0 248 kB nicolo-ribaudo
npm/@babel/types@7.25.4 environment 0 2.48 MB nicolo-ribaudo
npm/@metamask/eth-snap-keyring@4.4.0 None +1 123 kB
npm/@metamask/rpc-errors@6.4.0 None 0 165 kB metamaskbot
npm/@metamask/slip44@4.0.0 None 0 136 kB metamaskbot
npm/@metamask/snaps-controllers@9.11.1 None +1 1.71 MB danfinlay, gudahtt, kumavis, ...8 more
npm/@metamask/snaps-rpc-methods@11.5.0 None 0 1.23 MB danfinlay, gudahtt, kumavis, ...8 more
npm/@metamask/snaps-utils@8.4.1 None 0 1.34 MB danfinlay, gudahtt, kumavis, ...8 more
npm/@metamask/utils@9.3.0 None 0 706 kB metamaskbot
npm/@testing-library/dom@7.31.2 environment +3 3.14 MB testing-library-bot
npm/dom-accessibility-api@0.5.16 None 0 257 kB eps1lon
npm/lz-string@1.5.0 None 0 176 kB pieroxy
npm/undici-types@6.19.8 None 0 84.2 kB matteo.collina

🚮 Removed packages: npm/@babel/generator@7.24.10, npm/@babel/helper-annotate-as-pure@7.22.5, npm/@babel/helper-create-class-features-plugin@7.24.5, npm/@babel/helper-module-imports@7.24.3, npm/@babel/helper-plugin-utils@7.24.5, npm/@babel/helper-skip-transparent-expression-wrappers@7.22.5, npm/@babel/helper-validator-option@7.23.5, npm/@babel/parser@7.24.8, npm/@babel/plugin-syntax-jsx@7.24.1, npm/@babel/plugin-syntax-typescript@7.24.1, npm/@babel/plugin-transform-modules-commonjs@7.24.1, npm/@babel/plugin-transform-typescript@7.24.5, npm/@babel/preset-typescript@7.24.1, npm/@babel/runtime@7.24.8, npm/@babel/traverse@7.24.8, npm/@babel/types@7.24.9, npm/@metamask/eth-snap-keyring@4.3.3, npm/@metamask/rpc-errors@6.3.1, npm/@metamask/snaps-controllers@9.7.0, npm/@metamask/snaps-rpc-methods@11.1.1, npm/@metamask/utils@9.2.1, npm/@testing-library/dom@7.22.2, npm/dom-accessibility-api@0.5.0, npm/eth-rpc-errors@4.0.3, npm/json-rpc-engine@6.1.0

View full report↗︎

@Gudahtt
Copy link
Member Author

Gudahtt commented Oct 21, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot
Copy link
Collaborator

Builds ready [fb8ead2]
Page Load Metrics (1943 ± 128 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17328391883478229
domContentLoaded161425691905242116
load164727431943267128
domInteractive2398512210

@Gudahtt Gudahtt closed this Oct 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants