Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cherry-pick ENS resolution fix [this is a test - please ignore] #27995

Closed
wants to merge 3 commits into from

Commits on Oct 21, 2024

  1. fix(deps): update from eth-rpc-errors to @metamask/rpc-errors (cause …

    …edition) (#24496)
    
    - Upgrade from obsolete `eth-rpc-errors` to `@metamask/rpc-errors`
      - This introduce handling of error causes
    
    See [here](MetaMask/rpc-errors#140) for some
    context.
    
    [![Open in GitHub
    Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24496?quickstart=1)
    
    - #22871
    
    - [x] MetaMask/rpc-errors#158
    - [x] MetaMask/rpc-errors#144
      - [x] MetaMask/rpc-errors#140
    
    - #22875
    
    - [x] I’ve followed [MetaMask Coding
    Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
    - [x] I've completed the PR template to the best of my ability
    - [x] I’ve included tests if applicable
    - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [x] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    legobeat authored and Gudahtt committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    b4c1f9c View commit details
    Browse the repository at this point in the history
  2. chore(deps): upgrade from json-rpc-engine to @metamask/json-rpc-engine (

    #22875)
    
    - #27784
    - MetaMask/eth-json-rpc-middleware#335
    - #27917
    - #18510
    - #15250
    - MetaMask/metamask-improvement-proposals#36
    
    - [x] #24496
    
    - #24496
    
    - [x] I’ve followed [MetaMask Coding
    Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
    - [x] I've clearly explained what problem this PR is solving and how it
    is solved.
    - [x] I've linked related issues
    - [x] I've included manual testing steps
    - [x] I've included screenshots/recordings if applicable
    - [x] I’ve included tests if applicable
    - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [x] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    - [x] I’ve properly set the pull request status:
      - [x] In case it's not yet "ready for review", I've set it to "draft".
    - [x] In case it's "ready for review", I've changed it from "draft" to
    "non-draft".
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    legobeat authored and Gudahtt committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    0914812 View commit details
    Browse the repository at this point in the history
  3. Update LavaMoat policies

    metamaskbot committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    fb8ead2 View commit details
    Browse the repository at this point in the history