-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jl/caip25 permission migration/metamask controller test #28012
Merged
jiexi
merged 7 commits into
caip25-permission-migration
from
jl/caip25-permission-migration/metamask-controller-test
Oct 22, 2024
Merged
Jl/caip25 permission migration/metamask controller test #28012
jiexi
merged 7 commits into
caip25-permission-migration
from
jl/caip25-permission-migration/metamask-controller-test
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…migration/metamask-controller-test
…migration/metamask-controller-test
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [e1a3047]
Page Load Metrics (2015 ± 178 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
…migration/metamask-controller-test
Builds ready [7a67135]
Page Load Metrics (2034 ± 283 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
…migration/metamask-controller-test
jiexi
deleted the
jl/caip25-permission-migration/metamask-controller-test
branch
October 22, 2024 22:25
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve test coverage of MetamaskController
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist