Jl/caip25 permission migration/metamask controller test

[jiexi]

Description

Improve test coverage of MetamaskController

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [e1a3047]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2015 ± 178 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1689	2979	2018	382	183
		domContentLoaded	1678	2912	1987	364	175
		load	1692	2957	2015	371	178
		domInteractive	17	209	63	49	23
		backgroundConnect	10	82	30	21	10
		firstReactRender	46	134	83	25	12
		getState	4	68	24	22	10
		initialActions	0	1	0	0	0
		loadScripts	1181	2270	1490	300	144
		setupStore	12	78	32	23	11
		uiStartup	1846	3244	2221	403	194

Bundle size diffs [🚀 Bundle size reduced!]

• background: -25.19 KiB (-0.56%)
• ui: 593 Bytes (0.01%)
• common: -120.86 KiB (-1.53%)

[metamaskbot]

Builds ready [7a67135]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2034 ± 283 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	328	3355	1789	569	273
		domContentLoaded	1652	3623	1912	421	202
		load	1711	3954	2034	590	283
		domInteractive	28	179	61	35	17
		backgroundConnect	11	1114	117	252	121
		firstReactRender	49	265	106	47	23
		getState	4	190	31	48	23
		initialActions	0	0	0	0	0
		loadScripts	1190	2785	1425	339	163
		setupStore	11	137	40	39	19
		uiStartup	1866	5164	2333	840	403

Bundle size diffs [🚀 Bundle size reduced!]

• background: -25.19 KiB (-0.56%)
• ui: 593 Bytes (0.01%)
• common: -120.86 KiB (-1.53%)