Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jl/caip mutlichain migrate core convert create session ts #28020

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Oct 22, 2024

Description

Convert wallet_createSession to ts

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Oct 22, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask-previews/multichain@0.0.0-preview-e34032be Transitive: environment, filesystem, network +14 2.46 MB metamaskbot

🚮 Removed packages: npm/@metamask-previews/multichain@0.0.0-preview-257618a8

View full report↗︎

@jiexi jiexi marked this pull request as ready for review October 22, 2024 20:28
@jiexi jiexi requested a review from a team as a code owner October 22, 2024 20:28
@jiexi jiexi merged commit 049493e into jl/caip-multichain-migrate-core Oct 22, 2024
33 of 50 checks passed
@jiexi jiexi deleted the jl/caip-mutlichain-migrate-core-convert-createSession-ts branch October 22, 2024 20:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants