Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump asset controllers to 39 + polling API #28025

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Oct 22, 2024

Description

Bumps the asset controllers to 39. In this version, the polling API has changed from startPollingByNetworkClientId to a more flexible startPolling that can accept any input. The usePolling hook is modified to accommodate this.

Open in GitHub Codespaces

Related issues

Manual testing steps

Should be no noticeable changes. Currency rates should continue to be fetched. Try switching between chains with different native currencies like mainnet, polygon, bnb and verify the native token has fiat prices.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Oct 22, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@metamask/controller-utils@11.3.0

View full report↗︎

@bergeron
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot
Copy link
Collaborator

Builds ready [04ea3d6]
Page Load Metrics (1938 ± 90 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint38122781867384185
domContentLoaded16912265190417182
load17002283193818790
domInteractive16190583718
backgroundConnect9185374019
firstReactRender51208924119
getState45622199
initialActions00000
loadScripts12231730140915072
setupStore1485382512
uiStartup189127692156230111
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -34 Bytes (-0.00%)
  • ui: -38 Bytes (-0.00%)
  • common: -6.77 KiB (-0.09%)

@bergeron bergeron marked this pull request as ready for review October 23, 2024 21:52
@bergeron bergeron requested review from a team as code owners October 23, 2024 21:52
@bergeron bergeron changed the title chore: bump asset controllers to 39 chore: bump asset controllers to 39 + polling API Oct 23, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [cf66072]
Page Load Metrics (1832 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16842400183915776
domContentLoaded16352384179015775
load16462409183216579
domInteractive14199574722
backgroundConnect11109423014
firstReactRender43122742311
getState476252311
initialActions01000
loadScripts11911917132715172
setupStore1089382411
uiStartup18282623205018488
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -34 Bytes (-0.00%)
  • ui: -38 Bytes (-0.00%)
  • common: -6.77 KiB (-0.09%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants