Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust spacing of quote rate in swaps #28051

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

martahj
Copy link
Contributor

@martahj martahj commented Oct 23, 2024

Description

Cherry-pick of #28016 into v12.6

Open in GitHub Codespaces

Manual testing steps

  1. Start a swap
  2. Notice that the quote rate is back on one line and the value is left-aligned

Screenshots/Recordings

Before

Screenshot 2024-10-11 at 11 32 09 AM

After

Screenshot 2024-10-22 at 12 13 50 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**

The [PR to remove the legacy swaps
code](#27679)
inadvertently caused a misalignment of the quote rate. This PR re-aligns
it to be where it is expected.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28016?quickstart=1)

## **Manual testing steps**

1. Start a swap
2. Notice that the quote rate is back on one line and the value is
left-aligned

## **Screenshots/Recordings**

### **Before**

![Screenshot 2024-10-11 at 11 32
09 AM](https://github.com/user-attachments/assets/aae5da2f-ae66-46f5-9168-6c6ed496a2a8)


### **After**

<img width="359" alt="Screenshot 2024-10-22 at 12 13 50 PM"
src="https://github.com/user-attachments/assets/f5974e8a-62a6-464e-a037-b7ce38774f42">


## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 23, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [18186cf]
Page Load Metrics (2059 ± 116 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint175231812088313150
domContentLoaded17362472200819192
load174727632059241116
domInteractive16210574522
backgroundConnect10395569244
firstReactRender492791316029
getState5233385426
initialActions01000
loadScripts13081835148313264
setupStore11163404019
uiStartup195134372397420202
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@martahj martahj marked this pull request as ready for review October 23, 2024 18:09
@martahj martahj requested a review from a team as a code owner October 23, 2024 18:09
Copy link
Contributor

@davibroc davibroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it and it works

@martahj martahj merged commit b940d04 into Version-v12.6.0 Oct 23, 2024
77 of 78 checks passed
@martahj martahj deleted the cherrypick-quote-alignment branch October 23, 2024 20:56
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template QA Passed team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants