Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken not existing type file import #28055

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Oct 23, 2024

Description

In a previous PR #26172, a Storybook configuration was added, but it pointed to a types file that does not exist. This PR resolves that issue by correctly configuring the Storybook to reference the appropriate types or by removing the invalid reference if no replacement exists.

Open in GitHub Codespaces

Related issues

Fixes: #26172

Manual testing steps

  1. Navigate to the Storybook instance in your local environment.
  2. Ensure that the Storybook runs without any errors related to missing types files.
  3. Test the affected components to confirm they render and function as expected.

Screenshots/Recordings

Before

Screenshot 2024-10-23 at 3 32 50 PM

After

Storybook still works

Screenshot 2024-10-23 at 3 35 20 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g., pulled and built the branch, run the app, tested the code being changed).
  • I confirm that this PR addresses all acceptance criteria described and includes necessary testing evidence like recordings or screenshots.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Oct 23, 2024
@georgewrmarshall georgewrmarshall self-assigned this Oct 23, 2024
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner October 23, 2024 22:35
@georgewrmarshall georgewrmarshall requested a review from a team October 23, 2024 22:35
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@@ -1,9 +1,8 @@
import React from 'react';
import { Meta, Story } from '@storybook/react';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates story to CSF3.0 format

Screenshot 2024-10-23 at 3 39 23 PM

import TokenCurrencyDisplay from './token-currency-display.component';
import { TokenCurrencyDisplayProps } from './token-currency-display.types';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes non-existent types file

@metamaskbot
Copy link
Collaborator

Builds ready [8b523d6]
Page Load Metrics (2057 ± 82 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17772475206115775
domContentLoaded17482451201516077
load17822521205717082
domInteractive178443199
backgroundConnect8101442613
firstReactRender50282974924
getState593312512
initialActions01000
loadScripts12671938149614770
setupStore14102432512
uiStartup19872768231018488
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants