-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken not existing type file import #28055
base: develop
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
521ff73
to
8b523d6
Compare
@@ -1,9 +1,8 @@ | |||
import React from 'react'; | |||
import { Meta, Story } from '@storybook/react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import TokenCurrencyDisplay from './token-currency-display.component'; | ||
import { TokenCurrencyDisplayProps } from './token-currency-display.types'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removes non-existent types file
Builds ready [8b523d6]
Page Load Metrics (2057 ± 82 ms)
Bundle size diffs
|
Description
In a previous PR #26172, a Storybook configuration was added, but it pointed to a types file that does not exist. This PR resolves that issue by correctly configuring the Storybook to reference the appropriate types or by removing the invalid reference if no replacement exists.
Related issues
Fixes: #26172
Manual testing steps
Screenshots/Recordings
Before
After
Storybook still works
Pre-merge author checklist
Pre-merge reviewer checklist