Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump signature controller to 20.1.0 #28064

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Oct 24, 2024

Description

This PR applies recent changes in signature controller.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3298

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner October 24, 2024 08:24
@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Oct 24, 2024
@OGPoyraz OGPoyraz changed the title Bump signature controller to 20.0.1 fix: Bump signature controller to 20.0.1 Oct 24, 2024
Copy link

socket-security bot commented Oct 24, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/signature-controller@20.1.0 None +2 440 kB metamaskbot

🚮 Removed packages: npm/@metamask/signature-controller@20.0.0

View full report↗︎

package.json Outdated
@@ -356,7 +356,7 @@
"@metamask/safe-event-emitter": "^3.1.1",
"@metamask/scure-bip39": "^2.0.3",
"@metamask/selected-network-controller": "^18.0.2",
"@metamask/signature-controller": "^20.0.0",
"@metamask/signature-controller": "^20.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean 20.1.0?

@OGPoyraz OGPoyraz changed the title fix: Bump signature controller to 20.0.1 fix: Bump signature controller to 20.1.0 Oct 24, 2024
@OGPoyraz
Copy link
Member Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot metamaskbot requested a review from a team as a code owner October 24, 2024 09:19
@metamaskbot
Copy link
Collaborator

Builds ready [31bf4d8]
Page Load Metrics (2054 ± 62 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17802345206213163
domContentLoaded17242334202113364
load17822348205413062
domInteractive2498462110
backgroundConnect1187302211
firstReactRender632851194723
getState666322412
initialActions01000
loadScripts12561700150310952
setupStore1283302612
uiStartup19932664231817885
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 18.11 KiB (0.41%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants