Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [POM] Migrate onboarding infura call privacy e2e tests #28079

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Oct 24, 2024

Description

This PR migrates onboarding infura call privacy e2e tests to TypeScript and Page Object Model (POM) pattern, improving test stability and maintainability, it also reduced flakiness.

Open in GitHub Codespaces

Related issues

Fixes: #28080

Manual testing steps

Check code readability, make sure tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

devin-ai-integration bot and others added 21 commits October 18, 2024 09:57
Removed test files that were migrated to TypeScript:
- test/e2e/tests/privacy/basic-functionality.spec.js
- test/e2e/tests/privacy/onboarding-privacy.spec.js
…k/metamask-extension into chloe-migrate-onboarding

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner October 24, 2024 16:00
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-ai AI team (for the Devin AI bot) label Oct 24, 2024
@chloeYue chloeYue marked this pull request as draft October 24, 2024 16:01
@chloeYue chloeYue self-assigned this Oct 24, 2024
@chloeYue chloeYue changed the title chore: Convert privacy test files to TypeScript test: Convert privacy test files to TypeScript Oct 24, 2024
@chloeYue chloeYue changed the title test: Convert privacy test files to TypeScript test: [POM] Migrate onboarding infura call privacy e2e tests Oct 24, 2024
@chloeYue chloeYue marked this pull request as ready for review October 24, 2024 16:32
@metamaskbot
Copy link
Collaborator

Builds ready [390d5be]
Page Load Metrics (2066 ± 98 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint170426292078221106
domContentLoaded16912407202419091
load17022493206620498
domInteractive218150157
backgroundConnect999372713
firstReactRender492061123517
getState5115303115
initialActions01000
loadScripts12311744151514871
setupStore107225209
uiStartup190730542328282135
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ai AI team (for the Devin AI bot) team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[POM] Migrate onboarding infura call privacy e2e tests to page object modal and typescript
2 participants