Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Using button icon component for clikable icons #28082

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Oct 24, 2024

Description

Ref: #28038 (comment)

Related issues

Ref: https://github.com/MetaMask/MetaMask-planning/issues/3477

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Oct 24, 2024
@jpuri jpuri requested review from a team as code owners October 24, 2024 16:59
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Base automatically changed from sig_message_changes to develop October 24, 2024 17:20
@albertolive albertolive requested a review from a team as a code owner October 24, 2024 17:20
@metamaskbot
Copy link
Collaborator

Builds ready [1420f9a]
Page Load Metrics (1987 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17842386198717081
domContentLoaded17712357195515876
load17822446198717986
domInteractive298651189
backgroundConnect9116292512
firstReactRender491981003215
getState5130193115
initialActions01000
loadScripts12841723143612761
setupStore1388502512
uiStartup199830012234239115
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.24 KiB (0.02%)
  • common: 22 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants