-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Network filter asset list integration #28095
Draft
gambinish
wants to merge
16
commits into
feat/mmassets-432_network-filter-extension
Choose a base branch
from
feat/mmassets-432_network-filter-extension--integration--marketData
base: feat/mmassets-432_network-filter-extension
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Draft: Network filter asset list integration #28095
gambinish
wants to merge
16
commits into
feat/mmassets-432_network-filter-extension
from
feat/mmassets-432_network-filter-extension--integration--marketData
+108
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ask-extension into brian/asset-controller-39
…rk-filter-extension--integration--marketData
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/controller-utils@11.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opening this PR for some discussion on implementation strategies for network filter + cross chain asset list integrations in the hopes that it will be helpful in getting us on the same page. This PoC incorporates the marketData updates on core, along with some assets controller updates that integrate polling.
marketData
here: fix: should not reset market data after switch network core#4832To get this running, you will need to have core checked out to following commit:
401ba30f
Run
yarn && yarn build
In extension, resolve
@metamask/assets-controllers
tofile:../core/packages/assets-controllers
andyarn && FILTER_TOKENS_TOGGLE=1 yarn start
This should enable marketData to get fetched and appended as networks are changed. Note however, that we still are not preloading this market data for all chains when app first loads. I think that we should, unless there is a strong reason not to @salimtb
Additionally, you'll notice that balances are only getting fetched for the selected chain. I believe this is something to do with our
TokenTracker
implementation, but I need to look into this further.Related issues
TBD
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist