Skip to content

Commit

Permalink
fix: update usage of OP goerli to OP Sepolia (#8784)
Browse files Browse the repository at this point in the history
## **Description**

This PR's replaces the reference to OP goerli to OP sepolia.
Users that switch to OP goerli should still see the warning, and if they
have already made transactions on OP goerli, they should still see them
on activity tab.

Including the /compare diff URLs on core for visibility:

Core PR: MetaMask/core#3999


MetaMask/core@patch/mobile-transaction-controller-6-1-0...fix/update-OP-testnet-to-OP-sepolia


MetaMask/core@patch/mobile-transaction-controller-7-1-0...fix/update-OP-testnet

## **Related issues**

Fixes: MetaMask/mobile-planning#1569

CORE PR: MetaMask/core#3999

## **Manual testing steps**

1. Add OP goerli to your networks
2. You should still see the warning of OP goerli
3. Create transactions on OP goerli
4. You should see them in your activity tab

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**


https://github.com/MetaMask/metamask-mobile/assets/10994169/abd9976a-04c0-4d37-8659-8a620b637240

### **After**


https://github.com/MetaMask/metamask-mobile/assets/10994169/3eb5e152-2a18-4ae2-914f-f9899a641e64


## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
sahar-fehri authored Mar 6, 2024
1 parent 0c45fbf commit 1097298
Show file tree
Hide file tree
Showing 4 changed files with 4,077 additions and 769 deletions.
4 changes: 2 additions & 2 deletions app/store/migrations/025.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe('Migration #25', () => {
'0x61': true,
'0xa': true,
'0xa869': true,
'0x1a4': true,
'0xaa37dc': true,
'0x89': true,
'0x13881': true,
'0xa86a': true,
Expand Down Expand Up @@ -46,7 +46,7 @@ describe('Migration #25', () => {
'0x61': false,
'0xa': false,
'0xa869': false,
'0x1a4': false,
'0xaa37dc': false,
'0x89': false,
'0x13881': false,
'0xa86a': false,
Expand Down
2 changes: 1 addition & 1 deletion app/util/test/initial-background-state.json
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
"0x61": true,
"0xa": true,
"0xa869": true,
"0x1a4": true,
"0xaa37dc": true,
"0x89": true,
"0x13881": true,
"0xa86a": true,
Expand Down
10 changes: 6 additions & 4 deletions patches/@metamask+preferences-controller+4.4.3.patch
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
diff --git a/node_modules/@metamask/preferences-controller/dist/PreferencesController.d.ts b/node_modules/@metamask/preferences-controller/dist/PreferencesController.d.ts
index 323a8e8..8fa1856 100644
index 323a8e8..0c5ed1b 100644
--- a/node_modules/@metamask/preferences-controller/dist/PreferencesController.d.ts
+++ b/node_modules/@metamask/preferences-controller/dist/PreferencesController.d.ts
@@ -35,7 +35,8 @@ export interface PreferencesState extends BaseState {
Expand Down Expand Up @@ -54,8 +54,9 @@ index 323a8e8..8fa1856 100644
}
export default PreferencesController;
//# sourceMappingURL=PreferencesController.d.ts.map
\ No newline at end of file
diff --git a/node_modules/@metamask/preferences-controller/dist/PreferencesController.js b/node_modules/@metamask/preferences-controller/dist/PreferencesController.js
index 1a98ab0..a31d967 100644
index 1a98ab0..4ce2400 100644
--- a/node_modules/@metamask/preferences-controller/dist/PreferencesController.js
+++ b/node_modules/@metamask/preferences-controller/dist/PreferencesController.js
@@ -3,6 +3,29 @@ Object.defineProperty(exports, "__esModule", { value: true });
Expand All @@ -69,7 +70,7 @@ index 1a98ab0..a31d967 100644
+ BSC: '0x38',
+ BSC_TESTNET: '0x61',
+ OPTIMISM: '0xa',
+ OPTIMISM_TESTNET: '0x1a4',
+ OPTIMISM_SEPOLIA: '0xaa37dc',
+ POLYGON: '0x89',
+ POLYGON_TESTNET: '0x13881',
+ AVALANCHE: '0xa86a',
Expand Down Expand Up @@ -108,7 +109,7 @@ index 1a98ab0..a31d967 100644
+ [ETHERSCAN_SUPPORTED_CHAIN_IDS.BSC]: true,
+ [ETHERSCAN_SUPPORTED_CHAIN_IDS.BSC_TESTNET]: true,
+ [ETHERSCAN_SUPPORTED_CHAIN_IDS.OPTIMISM]: true,
+ [ETHERSCAN_SUPPORTED_CHAIN_IDS.OPTIMISM_TESTNET]: true,
+ [ETHERSCAN_SUPPORTED_CHAIN_IDS.OPTIMISM_SEPOLIA]: true,
+ [ETHERSCAN_SUPPORTED_CHAIN_IDS.POLYGON]: true,
+ [ETHERSCAN_SUPPORTED_CHAIN_IDS.POLYGON_TESTNET]: true,
+ [ETHERSCAN_SUPPORTED_CHAIN_IDS.AVALANCHE]: true,
Expand Down Expand Up @@ -193,3 +194,4 @@ index 1a98ab0..a31d967 100644
exports.PreferencesController = PreferencesController;
exports.default = PreferencesController;
//# sourceMappingURL=PreferencesController.js.map
\ No newline at end of file
Loading

0 comments on commit 1097298

Please sign in to comment.