Skip to content

Commit

Permalink
fix: Update ppom_release to fix fail ppom security validation check (#…
Browse files Browse the repository at this point in the history
…8605)

## **Description**
A recent geth update and how a eth_createAccessList request is handled
when passed certain variables, created an incompatibility with ppom
causing it to fail with `gasPrice must be non-zero after london fork,
data: None)`.

The incompatibility of ppom and the latest changes in geth is handled in
v1.4.1 of ppom_release.

## **Related issues**

Fixes: #8589

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
cryptotavares authored Feb 16, 2024
1 parent a867002 commit 215a969
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion app/lib/ppom/blockaid-version.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion app/lib/ppom/ppom.html.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ppom/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"devDependencies": {
"@babel/preset-env": "^7.22.6",
"@blockaid/ppom_release": "^1.4.0",
"@blockaid/ppom_release": "^1.4.1",
"babel-loader": "^9.1.2",
"binary-base64-loader": "^1.0.0",
"buffer": "^6.0.3",
Expand Down
8 changes: 4 additions & 4 deletions ppom/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -882,10 +882,10 @@
"@babel/helper-validator-identifier" "^7.22.20"
to-fast-properties "^2.0.0"

"@blockaid/ppom_release@^1.4.0":
version "1.4.0"
resolved "https://registry.yarnpkg.com/@blockaid/ppom_release/-/ppom_release-1.4.0.tgz#43646b09dfe8ec155da7df9ff0ba1ebedb4de04b"
integrity sha512-AEfEFXphHXeR91LSQ3pteENUjNlO6zmYPJBj/i2H/COXAR7nRGAJ6qf2LUXMiH4canwqTJfAeFNiFmxSJryCKg==
"@blockaid/ppom_release@^1.4.1":
version "1.4.1"
resolved "https://registry.yarnpkg.com/@blockaid/ppom_release/-/ppom_release-1.4.1.tgz#be445c5b664efe34498a29b29bfb7846a799e31c"
integrity sha512-wWtlz49PYvdzSnyfQ1Tj69m9vnF4iEAs/RBEcmBvldpBskY5PCkVzk+O0CT8v8M9v09VYKDdolFlIRuB+RLzMQ==

"@discoveryjs/json-ext@^0.5.0":
version "0.5.7"
Expand Down

0 comments on commit 215a969

Please sign in to comment.