Skip to content

Commit

Permalink
fix: Reorder prep_environment (#11467)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Move the `prep_environment` flow to before `install_detox`. This fixes
the failed detox cli installation part in `detox-setup.sh`

## **Related issues**

Fixes: #11465

## **Manual testing steps**

- Run the `pr_smoke_e2e_pipeline`
- Check that `install_detox` workflow successfully installs detox cli
within the tests. Here's an example of a failing one
https://app.bitrise.io/build/fa9fa7b1-80bf-4233-8bda-96cdaafe5ff4
- Tests should run successfully

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
Cal-L authored Sep 26, 2024
1 parent e93ea40 commit 4b8abcf
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions bitrise.yml
Original file line number Diff line number Diff line change
Expand Up @@ -644,8 +644,8 @@ workflows:
android_e2e_test:
before_run:
- setup
- install_detox
- prep_environment
- install_detox
after_run:
- notify_failure
steps:
Expand Down Expand Up @@ -737,8 +737,8 @@ workflows:
ios_api_specs:
before_run:
- setup
- install_detox
- prep_environment
- install_detox
after_run:
- notify_failure
steps:
Expand Down Expand Up @@ -890,8 +890,8 @@ workflows:
ios_e2e_test:
before_run:
- setup
- install_detox
- prep_environment
- install_detox
after_run:
- notify_failure
steps:
Expand Down

0 comments on commit 4b8abcf

Please sign in to comment.