Make test id constant

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
MetaMask · Jun 15, 2023 · a4969ea · a4969ea
1 parent a48bf1f
commit a4969ea
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/app/component-library/components/Banners/Banner/Banner.test.tsx b/app/component-library/components/Banners/Banner/Banner.test.tsx
@@ -8,6 +8,7 @@ import { BannerVariant } from './Banner.types';
 import { ButtonVariants } from '../../Buttons/Button';
 import { IconName } from '../../Icons/Icon';
 import { ButtonIconSizes, ButtonIconVariants } from '../../Buttons/ButtonIcon';
+import { TESTID_BANNER_CLOSE_BUTTON_ICON } from './foundation/BannerBase/BannerBase.constants';
 
 describe('Banner', () => {
   it('should render correctly', () => {
@@ -87,6 +88,8 @@ describe('Banner', () => {
 
     expect(wrapper).toMatchSnapshot();
     expect(await wrapper.findByText('Test Action Button')).toBeDefined();
-    expect(await wrapper.queryByTestId('banner-close-button')).toBeDefined();
+    expect(
+      await wrapper.queryByTestId(TESTID_BANNER_CLOSE_BUTTON_ICON),
+    ).toBeDefined();
   });
 });
diff --git a/app/component-library/components/Banners/Banner/__snapshots__/Banner.test.tsx.snap b/app/component-library/components/Banners/Banner/__snapshots__/Banner.test.tsx.snap
@@ -193,7 +193,6 @@ exports[`Banner should render correctly with a close button 1`] = `
     <TouchableOpacity
       accessible={true}
       activeOpacity={0.5}
-      data-testid="banner-close-button"
       onPress={[Function]}
       onPressIn={[Function]}
       onPressOut={[Function]}
@@ -205,6 +204,7 @@ exports[`Banner should render correctly with a close button 1`] = `
           "width": 24,
         }
       }
+      testID="banner-close-button-icon"
     >
       <SvgMock
         color="#0376C9"

diff --git a/...omponent-library/components/Banners/Banner/foundation/BannerBase/BannerBase.constants.tsx b/...omponent-library/components/Banners/Banner/foundation/BannerBase/BannerBase.constants.tsx
@@ -17,6 +17,9 @@ import { SAMPLE_ICON_PROPS } from '../../../../Icons/Icon/Icon.constants';
 // Internal dependencies.
 import { BannerBaseProps } from './BannerBase.types';
 
+// Test IDs
+export const TESTID_BANNER_CLOSE_BUTTON_ICON = 'banner-close-button-icon';
+
 // Defaults
 export const DEFAULT_BANNERBASE_TITLE_TEXTVARIANT = TextVariant.BodyLGMedium;
 export const DEFAULT_BANNERBASE_DESCRIPTION_TEXTVARIANT = TextVariant.BodyMD;

diff --git a/app/component-library/components/Banners/Banner/foundation/BannerBase/BannerBase.tsx b/app/component-library/components/Banners/Banner/foundation/BannerBase/BannerBase.tsx
@@ -22,6 +22,7 @@ import {
   DEFAULT_BANNERBASE_CLOSEBUTTON_BUTTONICONVARIANT,
   DEFAULT_BANNERBASE_CLOSEBUTTON_BUTTONICONSIZE,
   DEFAULT_BANNERBASE_CLOSEBUTTON_ICONNAME,
+  TESTID_BANNER_CLOSE_BUTTON_ICON,
 } from './BannerBase.constants';
 
 const BannerBase: React.FC<BannerBaseProps> = ({
@@ -69,7 +70,7 @@ const BannerBase: React.FC<BannerBaseProps> = ({
       {(onClose || closeButtonProps) && (
         <View style={styles.endAccessory}>
           <ButtonIcon
-            data-testid="banner-close-button"
+            testID={TESTID_BANNER_CLOSE_BUTTON_ICON}
             variant={DEFAULT_BANNERBASE_CLOSEBUTTON_BUTTONICONVARIANT}
             size={DEFAULT_BANNERBASE_CLOSEBUTTON_BUTTONICONSIZE}
             onPress={onClose || closeButtonProps?.onPress || noop}