feat: code quality

MetaMask · Mar 6, 2024 · a8195d4 · a8195d4
1 parent 94b9491
commit a8195d4
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 26 deletions.
diff --git a/app/actions/sdk/index.ts b/app/actions/sdk/index.ts
@@ -13,7 +13,6 @@ export enum ActionType {
   REMOVE_APPROVED_HOST = 'REMOVE_APPROVWED_HOST',
   SET_APPROVED_HOST = 'SET_APPROVED_HOST',
   RESET_APPROVED_HOSTS = 'RESET_APPROVED_HOSTS',
-  ADD_ANDROID_CONNECTION = 'ADD_ANDROID_CONNECTION',
   SET_CONNECTED = 'SET_CONNECTED',
   UPDATE_ANDROID_CONNECTION = 'UPDATE_ANDROID_CONNECTION',
   REMOVE_ANDROID_CONNECTION = 'REMOVE_ANDROID_CONNECTION',
@@ -59,12 +58,6 @@ export interface ResetApprovedHosts
   approvedHosts: ApprovedHosts;
 }
 
-export interface AddAndroidConnection
-  extends ReduxAction<ActionType.ADD_ANDROID_CONNECTION> {
-  channelId: string;
-  connection: ConnectionProps;
-}
-
 export interface UpdateAndroidConnection
   extends ReduxAction<ActionType.UPDATE_ANDROID_CONNECTION> {
   channelId: string;
@@ -101,7 +94,6 @@ export type Action =
   | SetApprovedHost
   | ResetApprovedHosts
   | UpdateWC2Metadata
-  | AddAndroidConnection
   | UpdateAndroidConnection
   | RemoveAndroidConnection
   | ResetAndroidConnections
@@ -169,15 +161,6 @@ export const resetApprovedHosts = (
   approvedHosts,
 });
 
-export const addAndroidConnection = (
-  channelId: string,
-  connection: ConnectionProps,
-): AddAndroidConnection => ({
-  type: ActionType.ADD_ANDROID_CONNECTION,
-  channelId,
-  connection,
-});
-
 export const updateAndroidConnection = (
   channelId: string,
   connection: ConnectionProps,

diff --git a/app/components/Views/AccountConnect/AccountConnect.tsx b/app/components/Views/AccountConnect/AccountConnect.tsx
@@ -106,7 +106,7 @@ const AccountConnect = (props: AccountConnectProps) => {
   const faviconSource = useFavicon(origin);
 
   const actualIcon = useMemo(
-    () => ({ uri: dappIconUrl } ?? faviconSource),
+    () => (dappIconUrl ? { uri: dappIconUrl } : faviconSource),
     [dappIconUrl, faviconSource],
   );
 

diff --git a/app/reducers/sdk/index.ts b/app/reducers/sdk/index.ts
@@ -89,14 +89,6 @@ const sdkReducer = (
           [action.channelId]: action.validUntil,
         },
       };
-    case ActionType.ADD_ANDROID_CONNECTION:
-      return {
-        ...state,
-        androidConnections: {
-          ...state.androidConnections,
-          [action.channelId]: action.connection,
-        },
-      };
     case ActionType.UPDATE_ANDROID_CONNECTION:
       return {
         ...state,