address review

MetaMask · Sep 6, 2024 · be044bd · be044bd
1 parent 1ffe760
commit be044bd
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 15 deletions.
diff --git a/app/core/MobilePortStream.js b/app/core/MobilePortStream.js
@@ -57,7 +57,7 @@ export default class PortDuplexStream extends Duplex {
    * @param {string} encoding Encoding to use when writing payload
    * @param {Function} cb Called when writing is complete or an error occurs
    */
-  _write = function (msg, enconding, cb) {
+  _write = function (msg, encoding, cb) {
     try {
       if (Buffer.isBuffer(msg)) {
         const data = msg.toJSON();

diff --git a/app/selectors/accountTrackerControllerReRenders.test.tsx b/app/selectors/accountTrackerControllerReRenders.test.tsx
@@ -342,9 +342,4 @@ describe('selectAccountBalanceByChainId', () => {
       expect(getByText(`Balance ${MOCK_BALANCE}`)).toBeDefined();
     });
   });
-});
-
-
-
-
-
+});
diff --git a/e2e/pages/Settings/AesCryptoTestForm.js b/e2e/pages/Settings/AesCryptoTestForm.js
@@ -151,7 +151,7 @@ class AesCryptoTestForm {
     );
   }
 
-  async generateSalt(saltBytesCount: string) {
+  async generateSalt(saltBytesCount) {
     await this.scrollUpToGenerateSalt();
     await Gestures.typeTextAndHideKeyboard(
       this.generateSaltBytesCountInput,
@@ -167,7 +167,7 @@ class AesCryptoTestForm {
     return responseFieldAtts.label;
   }
 
-  async generateEncryptionKey(password: string, salt: string) {
+  async generateEncryptionKey(password, salt) {
     await this.scrollUpToGenerateEncryptionKey();
     await Gestures.typeTextAndHideKeyboard(
       this.generateEncryptionKeyPasswordInput,
@@ -187,7 +187,7 @@ class AesCryptoTestForm {
     return responseFieldAtts.label;
   }
 
-  async encrypt(data: string, encryptionKey: string) {
+  async encrypt(data, encryptionKey) {
     await this.scrollToEncrypt();
     await Gestures.typeTextAndHideKeyboard(this.encryptDataInput, data);
     await Gestures.typeTextAndHideKeyboard(
@@ -197,7 +197,7 @@ class AesCryptoTestForm {
     await Gestures.waitAndTap(this.encryptButton);
   }
 
-  async decrypt(encryptionKey: string) {
+  async decrypt(encryptionKey) {
     await this.scrollToDecrypt();
     await Gestures.typeTextAndHideKeyboard(
       this.decryptPasswordInput,
@@ -206,7 +206,7 @@ class AesCryptoTestForm {
     await Gestures.waitAndTap(this.decryptButton);
   }
 
-  async encryptWithKey(encryptionKey: string, data: string) {
+  async encryptWithKey(encryptionKey, data) {
     await this.scrollToEncryptWithKey();
     await Gestures.typeTextAndHideKeyboard(
       this.encryptWithKeyEncryptionKeyInput,
@@ -216,7 +216,7 @@ class AesCryptoTestForm {
     await Gestures.waitAndTap(this.encryptWithKeyButton);
   }
 
-  async decryptWithKey(encryptionKey: string) {
+  async decryptWithKey(encryptionKey) {
     await this.scrollToDecryptWithKey();
     await Gestures.typeTextAndHideKeyboard(
       this.decryptWithKeyEncryptionKeyInput,

diff --git a/patches/@metamask+eslint-config-typescript+9.0.1.patch b/patches/@metamask+eslint-config-typescript+9.0.1.patch
@@ -1,12 +1,13 @@
 diff --git a/node_modules/@metamask/eslint-config-typescript/src/index.js b/node_modules/@metamask/eslint-config-typescript/src/index.js
-index 18b469e..64524b8 100644
+index 18b469e..63c6db8 100644
 --- a/node_modules/@metamask/eslint-config-typescript/src/index.js
 +++ b/node_modules/@metamask/eslint-config-typescript/src/index.js
-@@ -42,7 +42,7 @@ module.exports = {
+@@ -42,7 +42,8 @@ module.exports = {
        { allowDefinitionFiles: true },
      ],
      '@typescript-eslint/no-non-null-assertion': 'error',
 -    '@typescript-eslint/no-parameter-properties': 'error',
++    // no-parameter-properties is deprecating for this rule: https://typescript-eslint.io/rules/no-parameter-properties/
 +    '@typescript-eslint/parameter-properties': 'error',
      '@typescript-eslint/no-require-imports': 'error',
      '@typescript-eslint/prefer-for-of': 'error',