fix: fix total balance

MetaMask · Feb 20, 2024 · bf5a2ec · bf5a2ec
1 parent b1be882
commit bf5a2ec
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 19 deletions.
diff --git a/app/components/UI/Tokens/index.tsx b/app/components/UI/Tokens/index.tsx
@@ -520,10 +520,16 @@ const Tokens: React.FC<TokensI> = ({ tokens }) => {
   };
 
   const renderNetworth = () => {
-    const fiatBalance = `${renderFiat(
-      Engine.getTotalFiatAccountBalance(),
-      currentCurrency,
-    )}`;
+    const balance = Engine.getTotalFiatAccountBalance();
+    let total;
+    if (isOriginalNativeTokenSymbol) {
+      const tokenFiatTotal = balance?.tokenFiat ?? 0;
+      const ethFiatTotal = balance?.ethFiat ?? 0;
+      total = tokenFiatTotal + ethFiatTotal;
+    } else {
+      total = balance?.tokenFiat ?? 0;
+    }
+    const fiatBalance = `${renderFiat(total, currentCurrency)}`;
 
     const onOpenPortfolio = () => {
       const existingPortfolioTab = browserTabs.find((tab: BrowserTab) =>

diff --git a/app/components/Views/Settings/NetworksSettings/NetworkSettings/index.js b/app/components/Views/Settings/NetworksSettings/NetworkSettings/index.js
@@ -292,7 +292,6 @@ class NetworkSettings extends PureComponent {
     popularNetwork: {},
     showWarningModal: false,
     showNetworkDetailsModal: false,
-    matchedChain: null,
     isNameFieldFocused: false,
     isSymbolFieldFocused: false,
   };
@@ -335,7 +334,7 @@ class NetworkSettings extends PureComponent {
 
   componentDidMount = () => {
     this.updateNavBar();
-    const { route, networkConfigurations, matchedChainNetwork } = this.props;
+    const { route, networkConfigurations } = this.props;
 
     const isCustomMainnet = route.params?.isCustomMainnet;
     const networkTypeOrRpcUrl = route.params?.network;
@@ -388,10 +387,6 @@ class NetworkSettings extends PureComponent {
       this.setState({ addMode: true });
     }
 
-    this.setState({
-      matchedChainNetwork,
-    });
-
     setTimeout(() => {
       this.setState({
         inputWidth: { width: '100%' },
@@ -708,14 +703,15 @@ class NetworkSettings extends PureComponent {
    * Validates that symbol match with the chainId, setting a warningSymbol if is invalid
    */
   validateSymbol = async () => {
-    const { ticker, matchedChain } = this.state;
-    const { useSafeChainsListValidation } = this.props;
+    const { ticker } = this.state;
+    const { useSafeChainsListValidation, matchedChainNetwork } = this.props;
 
     if (!useSafeChainsListValidation) {
       return;
     }
 
-    const symbol = matchedChain?.nativeCurrency?.symbol ?? null;
+    const symbol =
+      matchedChainNetwork?.matchedChainNetwork?.nativeCurrency?.symbol ?? null;
 
     const symbolToUse = symbol === ticker ? undefined : symbol;
 
@@ -728,14 +724,14 @@ class NetworkSettings extends PureComponent {
    * Validates that name match with the chainId, setting a warningName if is invalid
    */
   validateName = async () => {
-    const { matchedChain, nickname } = this.state;
-    const { useSafeChainsListValidation } = this.props;
+    const { nickname } = this.state;
+    const { useSafeChainsListValidation, matchedChainNetwork } = this.props;
 
     if (!useSafeChainsListValidation) {
       return;
     }
 
-    const name = matchedChain?.chain ?? null;
+    const name = matchedChainNetwork?.matchedChainNetwork?.chain ?? null;
 
     const nameToUse = name === nickname ? undefined : name;
 

diff --git a/app/core/Engine.ts b/app/core/Engine.ts
@@ -1203,7 +1203,10 @@ class Engine {
     AccountTrackerController.refresh();
   }
 
-  getTotalFiatAccountBalance = () => {
+  getTotalFiatAccountBalance = (): {
+    ethFiat: number;
+    tokenFiat: number;
+  } => {
     const {
       CurrencyRateController,
       PreferencesController,
@@ -1270,8 +1273,10 @@ class Engine {
       );
     }
 
-    const total = ethFiat + tokenFiat;
-    return total;
+    return {
+      ethFiat,
+      tokenFiat,
+    };
   };
 
   /**