Skip to content

Commit

Permalink
fix: missing walletConnect prop (#9283)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

- Issue with `generateRawSignature` that didn't include the
`isWalletConnect` property.
- Issue undetected because of a missing type (set as any) in the method
signature.

## **Related issues**

Fixes: #9246

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
abretonc7s authored Apr 17, 2024
1 parent 420defa commit c8c78d6
Showing 1 changed file with 17 additions and 2 deletions.
19 changes: 17 additions & 2 deletions app/core/RPCMethods/RPCMethodMiddleware.ts
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,23 @@ const generateRawSignature = async ({
chainId,
channelId,
getSource,
isWalletConnect,
checkTabActive,
}: any) => {
}: {
version: string;
req: any;
hostname: string;
url: { current: string };
title: { current: string };
icon: { current: string | undefined };
analytics: { [key: string]: string | boolean };
chainId: number;
isMMSDK: boolean;
channelId?: string;
getSource: () => string;
isWalletConnect: boolean;
checkTabActive: any;
}) => {
const { SignatureController } = Engine.context;

const pageMeta = {
Expand All @@ -230,7 +245,7 @@ const generateRawSignature = async ({
channelId,
address: req.params[0],
chainId,
isWalletConnect: false,
isWalletConnect,
});

const rawSig = await SignatureController.newUnsignedTypedMessage(
Expand Down

0 comments on commit c8c78d6

Please sign in to comment.