Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Account token list is wiped out after upgrade and app restarts #10124

Closed
chrisleewilcox opened this issue Jun 26, 2024 · 3 comments
Closed
Labels
regression-RC-7.26.0 release-blocker This bug is blocking the next release Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-assets type-bug Something isn't working

Comments

@chrisleewilcox
Copy link
Contributor

Describe the bug

After upgrading to 7.26.0 RC2 the account token list is wiped out, no longer showing the tokens for the account after upgrade.

Workaround is to reimport using token detection link.

Expected behavior

Wallet configuration such as accounts, networks and tokens should properly persist after upgrade.

Screenshots/Recordings

Before upgrade:

Screen.Recording.2024-06-26.at.10.31.52.AM.mov

After upgrade:

Screen.Recording.2024-06-26.at.10.34.08.AM.mov

Steps to reproduce

GIVEN I have tokens displayed for wallet accounts
WHEN I upgrade
THEN tokens displayed persist after upgrade (FAIL: tokens are no longer displayed)

Error messages or log output

No response

Version

7.26.0

Build type

None

Device

iOS and android

Operating system

iOS, Android

Additional context

No response

Severity

No response

@chrisleewilcox chrisleewilcox added type-bug Something isn't working release-7.26.0 Issue or pull request that will be included in release 7.26.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets labels Jun 26, 2024
@metamaskbot metamaskbot added the regression-prod-7.26.0 Regression bug that was found in production in release 7.26.0 label Jun 26, 2024
@chrisleewilcox chrisleewilcox added release-blocker This bug is blocking the next release Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing regression-RC-7.26.0 and removed Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking regression-prod-7.26.0 Regression bug that was found in production in release 7.26.0 release-7.26.0 Issue or pull request that will be included in release 7.26.0 labels Jun 27, 2024
@chrisleewilcox chrisleewilcox changed the title [Bug]: Account token list is wiped out after upgrade [Bug]: Account token list is wiped out after upgrade and/or app restarts Jun 27, 2024
@chrisleewilcox chrisleewilcox changed the title [Bug]: Account token list is wiped out after upgrade and/or app restarts [Bug]: Account token list is wiped out after upgrade and app restarts Jun 27, 2024
@sahar-fehri
Copy link
Contributor

Hey @chrisleewilcox 👋 , I think this bug is similar to another one related to NFT state being reset, but there is a fix that was already submitted,

I was able to reproduce this behavior without the fix on the branch release/7.26.0, but with the fix, the upgrade works fine and i can see my imported tokens!

Is it possible that when reporting this issue, it was not on the latest version of the branch release/7.26.0?

@chrisleewilcox
Copy link
Contributor Author

Hi @sahar-fehri. Retested this on simulator with the latest on release branch and was not able to repro. Will test again in the next RC and will close.

@chrisleewilcox
Copy link
Contributor Author

Fixed by #10171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-RC-7.26.0 release-blocker This bug is blocking the next release Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-assets type-bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants