Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add tokenList iconUrl to IdentIcon component #10163

Merged
merged 7 commits into from
Jul 2, 2024

Conversation

OGPoyraz
Copy link
Member

Description

This PR aims to add support for IdentIcon component to use iconUrl for token entity from tokenList

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

Screenshot 2024-06-28 at 11 56 58

After

Screenshot 2024-06-28 at 11 41 13

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner June 28, 2024 10:00
@OGPoyraz OGPoyraz added the team-confirmations Push issues to confirmations team label Jun 28, 2024
vinistevam
vinistevam previously approved these changes Jul 1, 2024
jpuri
jpuri previously approved these changes Jul 1, 2024
@sleepytanya
Copy link
Contributor

sleepytanya commented Jul 1, 2024

Bitrise builds: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dc732094-b76d-4ac8-b836-4e905ccdba53?tab=artifacts
iPhone 15, iOS 17.5.1
Samsung S24+, Android 14

The app slows down significantly with simulations enabled. Waited for about 2 mins for Android and simulations never appeared.

iPhone:

ios.mov

Samsung:

android.mov

@OGPoyraz OGPoyraz dismissed stale reviews from jpuri and vinistevam via 552e392 July 2, 2024 03:49
@OGPoyraz OGPoyraz force-pushed the fix/simulation-known-token-icon branch from 749aab4 to 552e392 Compare July 2, 2024 03:49
@OGPoyraz OGPoyraz force-pushed the fix/simulation-known-token-icon branch from e062ee5 to b56bfd7 Compare July 2, 2024 03:59
@OGPoyraz OGPoyraz requested review from a team as code owners July 2, 2024 03:59
@OGPoyraz OGPoyraz added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1309941
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a7b36234-29a6-4a7c-ad06-4ec9df8ac126

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

matthewwalsh0
matthewwalsh0 previously approved these changes Jul 2, 2024
app/selectors/tokenListController.ts Show resolved Hide resolved
app/components/UI/Identicon/index.tsx Outdated Show resolved Hide resolved
vinistevam
vinistevam previously approved these changes Jul 2, 2024
@OGPoyraz OGPoyraz dismissed stale reviews from vinistevam and matthewwalsh0 via 693af59 July 2, 2024 09:47
Copy link

sonarcloud bot commented Jul 2, 2024

@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 693af59
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a02ce85e-3990-41aa-9594-23be768d5680

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 2, 2024
@OGPoyraz OGPoyraz linked an issue Jul 2, 2024 that may be closed by this pull request
@sleepytanya
Copy link
Contributor

Bitrise QA builds: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/613024ad-473f-4ac9-bc82-112fa1f68a89?tab=artifacts

iPhone15, Samsung S24+
Token icons displayed correctly, no performance issues.

Android:

Screen_Recording_20240702_124015_MetaMask-QA.mp4

iOS:

RPReplay_Final1719938743.MP4

@OGPoyraz OGPoyraz merged commit 53fc082 into main Jul 2, 2024
43 of 44 checks passed
@OGPoyraz OGPoyraz deleted the fix/simulation-known-token-icon branch July 2, 2024 16:54
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
@metamaskbot metamaskbot added the release-7.27.1 Issue or pull request that will be included in release 7.27.1 label Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.27.1 Issue or pull request that will be included in release 7.27.1 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Identicons displayed instead of token icons
6 participants