feat: Remove Account Snap Warning (Flask)

[owencraston]

Description

1. What is the reason for the change?

• This change adds an extra warning to users when trying to remove an account snap (https://metamask.github.io/snap-simple-keyring/latest/ for example) AND the user has snap accounts in their wallet
• Snap accounts are not managed/owned by metamask and therefore cannot be recovered in metamask. User's must manage and backup these accounts in the snaps UI.

2. What is the improvement/solution?

• Adds an extra layer of friction when trying to remove an account snap and the user has snap accounts in their wallet
• This is a FLASK ONLY feature

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/155

Manual testing steps

1. check this branch
2. open .js.env
3. ensure that export METAMASK_BUILD_TYPE=flask is set to flask (not main)
4. build the app on this branch
5. create/import a wallet
6. inside the mobile browser, open this URL: https://metamask.github.io/snap-simple-keyring/latest/
7. connect this snap
8. click create account, you can do this as many times as you want.
9. navigate back to the main wallet view
10. NOTICE there should be new accounts in your wallet with the name "Snap Account x"
11. Go to settings
12. navigate to snaps
13. locate the Snap simple keyring settings
14. scroll to the bottom of the page and click the red "Remove" button
15. Notice: new warning should pop up indicating that the user should backup these accounts before removing the snap
16. click continue
17. you should be prompted to type the name of the snap in the text input.
18. YOU SHOULD NOT BE ABLE TO REMOVE THE SNAP WITHOUT TYPING The CORRECT SNAP NAME
19. Once you type the correct snap name, you should be able to remove the snap
20. After clicking remove the snap should be removed.

Testing a non account snap

1. check this branch
2. open .js.env
3. ensure that export METAMASK_BUILD_TYPE=flask is set to flask (not main)
4. build the app on this branch
5. create/import a wallet
6. navigate to settings/snaps
7. click on the pre installed Message signing snap
8. click on the remove button at the bottom
9. THERE SHOULD NOT BE A WARNING

Testing removing a snap account without snap accounts in the wallet

1. check this branch
2. open .js.env
3. ensure that export METAMASK_BUILD_TYPE=flask is set to flask (not main)
4. build the app on this branch
5. create/import a wallet
6. inside the mobile browser, open this URL: https://metamask.github.io/snap-simple-keyring/latest/
7. connect this snap. Do not create any accounts this time.
8. Go to settings
9. navigate to snaps
10. locate the Snap simple keyring settings
11. scroll to the bottom of the page and click the red "Remove" button
12. There should be no warning pop up and the snap should be removed

Screenshots/Recordings

Extension Version

After

with snap accounts:

Screen.Recording.2024-10-01.at.5.49.52.PM.mov

Without snap accounts:

Untitled.mov

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f6a015c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1f5a0751-dc84-4204-abec-13abee142dcb

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1964984
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5d5be5a2-598a-43ef-803c-4dd0cfdbd0d6

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[k-g-j]

Passing initial manually testing! Good job 😄

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-03.at.10.49.17.mp4

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f853a41
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fe19e8a5-c15d-4c5e-adc7-d65bbb0866a4

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Jonathansoufer]

Left some minor comments, but excellent work overall!

[Cal-L]

Lgtm!