Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Incorrect message when adding network from Popular list #12492

Open
sleepytanya opened this issue Nov 29, 2024 · 8 comments · May be fixed by #12907
Open

[Bug]: Incorrect message when adding network from Popular list #12492

sleepytanya opened this issue Nov 29, 2024 · 8 comments · May be fixed by #12907
Assignees
Labels
regression-RC-7.37.0 Regression bug that was found in release candidate (RC) for release 7.37.0 release-blocker This bug is blocking the next release team-assets type-bug Something isn't working

Comments

@sleepytanya
Copy link
Contributor

sleepytanya commented Nov 29, 2024

Describe the bug

When a user adds a network from the Popular list, they encounter a message mentioning 'giving Undefined dapp origin permission', in 7.36.0 message didn't mention any dApps.
Additionally, if the user opts to 'Review' next to 'Network RPC URL', they are presented with a message that compares the current Infura RPC with a new one, such as https://flashbots.polygon-mainnet.com/.
Despite the incorrect message, this does not impact the functionality, and the network can still be successfully added using the default Infura RPC URL.

Expected behavior

Best guess on how adding additional network is suppose to work. Please consult with PM for specifics.

Scenario: Add additional (aka Popular) network from 'Select a network' modal

GIVEN I am on Wallet view
WHEN I tap network icon drop-down in upper left screen
AND I tap 'Add' link button for a network listed in 'Additional networks' section of 'Select a network' modal
THEN 'Add additional network' title in the pop-up modal is displayed (FAILED: 'Add custom network' is the title)
AND Alert messages are not shown (FAILED: Alert indicating can't verify custom network)
AND description for adding network and giving Undefined dapp permissions is not shown (FAILED: this description is displayed, seem like it should be only for adding network from dapp)
AND View details data matches additional network to be added
WHEN I tap Confirm
THEN pop-up modal confirms network is added (FAILED: network name does not match)
WHEN I tap 'Switch to network'
THEN app navigates to wallet view
AND new network added is selected/active for app
Scenario: Add network from dapp

GIVEN I am on browser view
AND I navigate to 'core.app'
WHEN I add Fuji network from 'core.app'
THEN Add <network name> modal is displayed
AND You're adding this network to MetaMask and giving 'core.app' permission to use it description is displayed
AND View details data matches network to be added
WHEN I tap 'Confirm'
THEN app switches network to new network added
Scenario: Add Popular network from Settings > Network
GIVEN I am on Settings > Network
AND I tap Add Network

Screenshots/Recordings

'Add custom network' message in 7.36.0 (1504):

File

Adding network 7.37.0 (1506):

addNetworkMessage.mov
Screenshot 2024-11-29 at 01 53 38 Screenshot 2024-11-29 at 01 54 02

Steps to reproduce

  1. Add a network from MM Popular list

Error messages or log output

No response

Detection stage

During release testing

Version

7.37.0

Build type

None

Device

iPhone 15

Operating system

iOS

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added type-bug Something isn't working Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets regression-RC-7.37.0 Regression bug that was found in release candidate (RC) for release 7.37.0 labels Nov 29, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Nov 29, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Nov 29, 2024
@Unik0rnMaggie
Copy link
Contributor

Reproduced on Android 14 - Pixel 6 Pro device:

add.network.mov

@Unik0rnMaggie
Copy link
Contributor

Same flashbots polygon message appears when trying to add popular networks via dapps like drpc or chainlist

Screenshot 2024-11-29 at 15 42 04 Screenshot 2024-11-29 at 15 44 17

@christopherferreira9
Copy link
Contributor

To add to this and because I figured it wasn't worth to have its own issue, the contents when adding a network via RPC are misaligned.

Screenshot 2024-11-29 at 5 06 24 PM

@Unik0rnMaggie
Copy link
Contributor

In version 7.37.0 (1511) warning still appears, but flashbots.polygon incorrect info disappeared:

Screen.Recording.2024-12-06.at.11.04.16.mov

@Unik0rnMaggie
Copy link
Contributor

Reproduced on QA build for Portfolio View feature, from here

Add.popular.network.mov

@chrisleewilcox chrisleewilcox added release-blocker This bug is blocking the next release and removed Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking labels Jan 7, 2025
@Unik0rnMaggie
Copy link
Contributor

Reproduced on v 7.38.0 (1523) from here

The message appears for all popular networks

Add.popular.network.mov

@bergeron bergeron self-assigned this Jan 8, 2025
@bergeron
Copy link
Contributor

bergeron commented Jan 8, 2025

Looks like there's a few bugs here.

  • When adding a network and clicking "review", the new URL is hardcoded to https://flashbots.polygon-mainnet.com here. This seems to occur in production, maybe devs thought it was still behind a flag.
Screen.Recording.2025-01-08.at.12.13.01.PM.mov
  • The message saying Undefined dapp origin when the network was added via popular list. Shouldn't mention dapps at all.

  • The warning messages seem backwards? It warns when users add popular networks built into MetaMask, but not when adding networks from dapps. Seems like it should either warn neither, or on dapp provided data since its less trusted.

@bergeron bergeron linked a pull request Jan 8, 2025 that will close this issue
7 tasks
@bergeron
Copy link
Contributor

bergeron commented Jan 9, 2025

fixing in #12907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-RC-7.37.0 Regression bug that was found in release candidate (RC) for release 7.37.0 release-blocker This bug is blocking the next release team-assets type-bug Something isn't working
Projects
Status: To be fixed
Status: To be fixed
Development

Successfully merging a pull request may close this issue.

5 participants