-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Incorrect message when adding network from Popular list #12492
Comments
Reproduced on Android 14 - Pixel 6 Pro device: add.network.mov |
In version 7.37.0 (1511) warning still appears, but flashbots.polygon incorrect info disappeared: Screen.Recording.2024-12-06.at.11.04.16.mov |
Reproduced on QA build for Portfolio View feature, from here Add.popular.network.mov |
Reproduced on v 7.38.0 (1523) from here The message appears for all popular networks Add.popular.network.mov |
Looks like there's a few bugs here.
Screen.Recording.2025-01-08.at.12.13.01.PM.mov
|
fixing in #12907 |
Describe the bug
When a user adds a network from the Popular list, they encounter a message mentioning 'giving Undefined dapp origin permission', in 7.36.0 message didn't mention any dApps.
Additionally, if the user opts to 'Review' next to 'Network RPC URL', they are presented with a message that compares the current Infura RPC with a new one, such as https://flashbots.polygon-mainnet.com/.
Despite the incorrect message, this does not impact the functionality, and the network can still be successfully added using the default Infura RPC URL.
Expected behavior
Best guess on how adding additional network is suppose to work. Please consult with PM for specifics.
Screenshots/Recordings
'Add custom network' message in 7.36.0 (1504):
Adding network 7.37.0 (1506):
addNetworkMessage.mov
Steps to reproduce
Error messages or log output
No response
Detection stage
During release testing
Version
7.37.0
Build type
None
Device
iPhone 15
Operating system
iOS
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: