Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid transaction data used for approve transaction (#6833) #6914

Merged
merged 1 commit into from
Jul 26, 2023
Merged

fix: invalid transaction data used for approve transaction (#6833) #6914

merged 1 commit into from
Jul 26, 2023

Conversation

sethkfman
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Cherry pick of #6833

Screenshots/Recordings

NA

Issue

NA

Checklist

  • [NA] There is a related GitHub issue
  • [NA] Tests are included if applicable
  • [NA] Any added code is fully documented

@blackdevelopa @sethkfman
fix: invalid transaction data used for approve transaction (#6833)
f32d9ad 
* use valid txn data when approving txn

* rename variable
@sethkfman sethkfman requested a review from a team as a code owner July 26, 2023 22:16
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chrisleewilcox chrisleewilcox added the QA Passed A successful QA run through has been done label Jul 26, 2023
chrisleewilcox
chrisleewilcox approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug D 12 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 91 Code Smells

29.1% 29.1% Coverage
3.8% 3.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sethkfman sethkfman merged commit 7909a6f into release/7.3.1 Jul 26, 2023
11 of 12 checks passed
@sethkfman sethkfman deleted the fix/cherry-pick-6833 branch July 26, 2023 22:49
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sethkfman @chrisleewilcox @blackdevelopa