Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New json rpc for swaps #7509

Draft
wants to merge 70 commits into
base: main
Choose a base branch
from
Draft

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Oct 16, 2023

Description

This aims to implement a new JSON RPC method for swaps. This enables dapps to request swaps with metamask mobile wallet.

We can have more information from this MIP.

Screenshots/Recordings

Needs new recordings

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini marked this pull request as draft October 18, 2023 10:32
@tommasini tommasini changed the base branch from main to feat/swaps-on-send-flow October 27, 2023 15:35
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 27, 2023
@tommasini tommasini requested review from a team as code owners April 24, 2024 23:47
Copy link

sonarcloud bot commented May 20, 2024

@tommasini tommasini requested review from a team as code owners June 21, 2024 16:39
@jiexi
Copy link
Contributor

jiexi commented Jul 1, 2024

CAIP related changes look good to me

Copy link

sonarcloud bot commented Jul 2, 2024

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Sep 30, 2024
@tommasini tommasini marked this pull request as draft September 30, 2024 15:09
@github-actions github-actions bot removed the stale Issues that have not had activity in the last 90 days label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants