Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Missing METAMASK_BUILD_TYPE; set to 'main' for a standard release, or 'flask' for a canary flask release. The default value is 'main'. #8622

Closed
cain1980 opened this issue Feb 19, 2024 · 3 comments · Fixed by #8788
Closed

[Bug]: Missing METAMASK_BUILD_TYPE; set to 'main' for a standard release, or 'flask' for a canary flask release. The default value is 'main'. #8622

cain1980 opened this issue Feb 19, 2024 · 3 comments · Fixed by #8788
Assignees
@kylanhurt
Labels
external-contributor regression-prod-7.13.0 Regression bug that was found in production in release 7.13.0 release-7.19.0 Issue or pull request that will be included in release 7.19.0 Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild team-mobile-platform type-bug Something isn't working

Comments

@cain1980
Copy link

Describe the bug

Missing METAMASK_BUILD_TYPE; set to 'main' for a standard release, or 'flask' for a canary flask release. The default value is 'main'.

Expected behavior

No response

Screenshots/Recordings

No response

Steps to reproduce

yarn start:ios

Error messages or log output

No response

Version

7.13.0

Build type

None

Device

mac

Operating system

iOS

Additional context

No response

Severity

No response
@cain1980 cain1980 added the type-bug Something isn't working label Feb 19, 2024
@metamaskbot metamaskbot added external-contributor regression-prod-7.13.0 Regression bug that was found in production in release 7.13.0 labels Feb 19, 2024
@Bullcoiner Bullcoiner added Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild team-mobile-platform labels Feb 20, 2024
@Bullcoiner
Copy link

Hi There! Thank you for reporting this, it has been assigned to the appropriate team to be looked at. If possible can you please provide some more information about the issue you are experiencing?

@gauthierpetetin
Copy link
Contributor

Default MM build type: main
Default MM environment: local

@metamaskbot metamaskbot added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed ready-for-dev labels Mar 1, 2024
@kylanhurt kylanhurt linked a pull request Mar 1, 2024 that will close this issue
chore: Add instructions regarding tool versions and env variables in Readme #8788
Merged
13 tasks
@kylanhurt kylanhurt mentioned this issue Mar 1, 2024
Merged
13 tasks
@bdtren
Copy link

bdtren commented Mar 3, 2024

For a temp workaround, you can put these to the top of build.sh, below readonly REPO_ROOT_DIR="$(dirname "${__DIRNAME__}")":

METAMASK_BUILD_TYPE="main"
METAMASK_ENVIRONMENT="local"

kylanhurt added a commit that referenced this issue Mar 5, 2024
@kylanhurt
chore: Add instructions regarding tool versions and env variables in …
e9f3351 
…Readme (#8788)

## **Description**

The MetaMask Mobile Platform team has identified improvements to the
read me as a way improving the developer experience and onboarding.

## **Related issues**

Fixes: #8622  improves the effectiveness of the read me. 

## **Manual testing steps**

1. Read the repository Readme.md file

## **Screenshots/Recordings**

### Before:


https://github.com/MetaMask/metamask-mobile/assets/6249205/2aad15cf-a542-4514-b112-7f25800b1387

### After:


https://github.com/MetaMask/metamask-mobile/assets/6249205/42d0ca2c-5e0a-4000-855c-461e95bb9778

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 5, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylanhurt kylanhurt

Labels
external-contributor regression-prod-7.13.0 Regression bug that was found in production in release 7.13.0 release-7.19.0 Issue or pull request that will be included in release 7.19.0 Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild team-mobile-platform type-bug Something isn't working
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Add instructions regarding tool versions and env variables in Readme MetaMask/metamask-mobile
6 participants
@kylanhurt @gauthierpetetin @bdtren @metamaskbot @cain1980 @Bullcoiner