Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Incorrect balance displayed when adding a token with lots of decimals #8623

Open
seaona opened this issue Feb 19, 2024 · 7 comments
Open
Labels
Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets type-bug Something isn't working

Comments

@seaona
Copy link
Contributor

seaona commented Feb 19, 2024

Describe the bug

Problem: whenever I am adding a token with lots of decimals (i.e. 30) I can see how the balance displayed is incorrect.

Expected behavior

I'm expecting to see 10 TST like in Extension

Screenshots/Recordings

incorrect-balance-lots-decimals.mp4

Steps to reproduce

  1. Go to the test dapp https://metamask.github.io/test-dapp/
  2. Connect MM
  3. Deploy an ERC20 token withg 30 decimals
  4. Click Add Tokens to wallet
  5. See balance displayed is 4.2498937....e+26, when it should be 10

Error messages or log output

No response

Version

7.16.0 rc branch but seems an old issue

Build type

None

Device

Pixel 6

Operating system

iOS, Android

Additional context

No response

Severity

No response

@seaona seaona added the type-bug Something isn't working label Feb 19, 2024
@Bullcoiner Bullcoiner added Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild team-extension-platform team-mobile-platform team-assets and removed team-extension-platform labels Feb 20, 2024
@Bullcoiner
Copy link

Hi There! Thank you for reporting this, it has been assigned to a team to be looked at.

@gauthierpetetin
Copy link
Contributor

Hi @salimtb , we weren't sure during the bug triage session: is this something you've been working on recently?

@salimtb
Copy link
Contributor

salimtb commented Mar 1, 2024

hey @gauthierpetetin ,
i increased the number of decimals that we can support , but i did it lot of month ago.
but i have good knowledge on this, maybe we need to increase it again, i can work on it

@salimtb
Copy link
Contributor

salimtb commented Mar 1, 2024

@gauthierpetetin the bug is on mobile , the work that i have done was on extension

@gauthierpetetin
Copy link
Contributor

Ok makes sense, thanks for the explanation!

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label May 31, 2024
@gauthierpetetin gauthierpetetin removed the stale Issues that have not had activity in the last 90 days label May 31, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Aug 29, 2024
@gauthierpetetin gauthierpetetin added Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking and removed stale Issues that have not had activity in the last 90 days Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild labels Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets type-bug Something isn't working
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

4 participants