-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ramp): add event when user expands quotes #8729
Conversation
Co-authored-by: Cal Leung <cleun007@gmail.com>
e286905
to
9971337
Compare
Leaving this as a draft until the event properties are reviewed. Can you please take a look @lorenzosantos? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/ramp-previously-used-provider #8729 +/- ##
======================================================================
- Coverage 41.53% 41.47% -0.06%
======================================================================
Files 1260 1263 +3
Lines 30677 30679 +2
Branches 3024 3028 +4
======================================================================
- Hits 12741 12724 -17
- Misses 17175 17193 +18
- Partials 761 762 +1 ☔ View full report in Codecov by Sentry. |
9971337
to
b0dca32
Compare
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
b0dca32
to
7bffd2e
Compare
7bffd2e
to
2b28c12
Compare
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/305a07c0-53f6-41d3-89a5-de304dc71df0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Bitrise✅✅✅ Commit hash: 67e3d80 Note
|
LGTM, I verified the event appeared in logs with Pedro ✅ |
@Cal-L can you please re-review, this has just changed the base branch 🙏 |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note
This PR is based on #8680
Description
This PR adds an event when the user expands the quotes to explore more options in the simplified view
Related issues
https://consensyssoftware.atlassian.net/browse/ONRAMP-1407
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist