-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: PPOM - No blockaid data is included in Metrics events for transactions triggered from inside the wallet #8824
Labels
release-7.21.0
Issue or pull request that will be included in release 7.21.0
release-7.22.0
Issue or pull request that will be included in release 7.22.0
release-7.23.0
Issue or pull request that will be included in release 7.23.0
Sev2-normal
An issue that may lead to users misunderstanding some limited risks they are taking
team-confirmations
Push issues to confirmations team
team-confirmations-secure-ux
DEPRECATED: please use "team-confirmations" label instead
type-bug
Something isn't working
Comments
seaona
added
type-bug
Something isn't working
team-confirmations-secure-ux
DEPRECATED: please use "team-confirmations" label instead
labels
Mar 3, 2024
metamaskbot
added
the
regression-prod-7.17.0
Regression bug that was found in production in release 7.17.0
label
Mar 3, 2024
bschorchit
added
Sev2-normal
An issue that may lead to users misunderstanding some limited risks they are taking
and removed
regression-prod-7.17.0
Regression bug that was found in production in release 7.17.0
labels
Mar 4, 2024
Hey team! Please add your planning poker estimate with Zenhub @blackdevelopa @digiwand @jpuri @seaona @segun |
Please add your planning poker estimate with Zenhub @pedronfigueiredo |
NOTE: We don't send blockaid metrics on transaction started for DAPP as well. Only for rejected/cancelled. |
7 tasks
segun
added a commit
that referenced
this issue
Apr 11, 2024
## **Description** We should send PPOM/Blockaid metrics parameters when a transaction from wallet is rejected. Right now we only send the metrics when the transaction is approved. ## **Related issues** Fixes: [#8824](#8824) ## **Manual testing steps** 1. Enable Blockiad 2. Enable metrics 3. Initiate a malicious tx from inside the wallet 4. Cancel/Reject the transaction 5. See that PPOM Metrics is sent in the logs ## **Screenshots/Recordings** ### **Before** https://github.com/MetaMask/metamask-mobile/assets/54408225/12153f52-baeb-4344-b6f6-0c00c2a1d1fc ### **After** https://github.com/MetaMask/metamask-mobile/assets/44811/efea6aa9-96f7-4b57-915c-5fe946daabdf ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
metamaskbot
added
the
release-7.21.0
Issue or pull request that will be included in release 7.21.0
label
Apr 11, 2024
7 tasks
segun
added a commit
that referenced
this issue
Apr 16, 2024
## **Description** We should send PPOM/Blockaid metrics parameters when a transaction from wallet is rejected. Right now we only send the metrics when the transaction is approved. ## **Related issues** Fixes: [#8824](#8824) ## **Manual testing steps** 1. Enable Blockiad 2. Enable metrics 3. Initiate a malicious tx from inside the wallet 4. Cancel/Reject the transaction 5. See that PPOM Metrics is sent in the logs ## **Screenshots/Recordings** ### **Before** https://github.com/MetaMask/metamask-mobile/assets/54408225/12153f52-baeb-4344-b6f6-0c00c2a1d1fc ### **After** https://github.com/MetaMask/metamask-mobile/assets/44811/efea6aa9-96f7-4b57-915c-5fe946daabdf ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
metamaskbot
added
the
release-7.22.0
Issue or pull request that will be included in release 7.22.0
label
Apr 16, 2024
re-opening as I'm still not seeing this fixed 🤔 |
7 tasks
metamaskbot
added
the
release-7.23.0
Issue or pull request that will be included in release 7.23.0
label
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release-7.21.0
Issue or pull request that will be included in release 7.21.0
release-7.22.0
Issue or pull request that will be included in release 7.22.0
release-7.23.0
Issue or pull request that will be included in release 7.23.0
Sev2-normal
An issue that may lead to users misunderstanding some limited risks they are taking
team-confirmations
Push issues to confirmations team
team-confirmations-secure-ux
DEPRECATED: please use "team-confirmations" label instead
type-bug
Something isn't working
Describe the bug
Problem: there is no Blockaid information on metric events for transactions triggered from inside the wallet
Expected behavior
We should have the same metrics as we have for transactions triggered from a dapp, for the following events:
Screenshots/Recordings
no-metrics-tx-inside-wallet.mp4
Steps to reproduce
Error messages or log output
No response
Version
7.17.0
Build type
None
Device
Pixel 6
Operating system
Android
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: