7.26.0 #10052

github-actions · 2024-06-20T14:57:32Z

This is the release candidate for version 7.26.0.

github-actions · 2024-06-21T03:57:38Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5e885ba
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5cf24bfa-5a89-4852-96d8-1f7049f30896

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

This PR cherry-picks #10039 --------- Co-authored-by: OGPoyraz <omergoktugpoyraz@gmail.com> Co-authored-by: LeoTM <1881059+leotm@users.noreply.github.com> Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>

github-actions · 2024-06-21T19:45:29Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

This PR cherry-picks #10055 Co-authored-by: SamuelSalas <samuel.salas.reyes@gmail.com>

merges release 7.24.3 tag in 7.26.0 --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com> Co-authored-by: sethkfman <Seth.Kaufman@consensys.net> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: hesterbruikman <hester.bruikman@consensys.net> Co-authored-by: EtherWizard33 <eric.lamontagne@consensys.net> Co-authored-by: EtherWizard33 <165834542+EtherWizard33@users.noreply.github.com> Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com> Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com> Co-authored-by: Cal Leung <cleun007@gmail.com> Co-authored-by: Omri Dan <61094771+omridan159@users.noreply.github.com> Co-authored-by: Christopher Ferreira <104831203+christopherferreira9@users.noreply.github.com> Co-authored-by: Daniel <80175477+dan437@users.noreply.github.com> Co-authored-by: yande <110056475+Andepande@users.noreply.github.com> Co-authored-by: Derek Brans <dbrans@gmail.com> Co-authored-by: LeoTM <1881059+leotm@users.noreply.github.com> Co-authored-by: Jony Bursztyn <jonathan@bursztyn.io> Co-authored-by: Curtis David <Curtis.David7@gmail.com> Co-authored-by: salimtb <salim.toubal@outlook.com> Co-authored-by: Wietze Bronkema <11412480+wtzb@users.noreply.github.com> Co-authored-by: Owen Craston <owen.craston@consensys.net> Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: Cal Leung <cal.leung@consensys.net> Co-authored-by: Mark Stacey <markjstacey@gmail.com> Co-authored-by: Vinicius Stevam <45455812+vinistevam@users.noreply.github.com>

This PR cherry-picks #10064 Co-authored-by: Daniel <80175477+dan437@users.noreply.github.com>

bump build number to 1355 for 7.26.0 RC2 This is for testing STX

This PR cherry-picks #10088 Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>

This PR cherry-picks #10099 Co-authored-by: infiniteflower <139582705+infiniteflower@users.noreply.github.com> Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>

This PR cherry-picks #10133 Co-authored-by: Mark Stacey <markjstacey@gmail.com>

## **Description** Related to this fix: #10135 Because v7.26.0 is one assets-controllers v26, so i made the same fix on this PR ## **Related issues** Fixes: #10132 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

This PR cherry-picks #10142

anaamolnar · 2024-07-01T20:50:21Z

Testing v7.26.0 Android Samsung A53

Browser regression:

✅ Scenario: Searching an invalid url and prompts the user with an error message:
✅ Scenario: Navigation with browser controls:
✅ Scenario: ENS website loads correctly:
✅ Scenario: From the browser I can successfully upload a picture:
❌ Scenario: Address bar:
At some point the browser stops responding and I keep having to restart the app
❌Scenario: Adding browser Favorites
Logo of the dapp is not displayed in favorites
✅ Scenario: Browser Options Menu:
Browser back button -
Share, Network change in wallet, & New Tab -
✅ Scenario: Visiting a malicious website prompts the user with the phishing detection warning:
❌ Scenario: Navigate to opensea.io, rarible.com, pancakeswap.finance, app.uniswap.org, and connect wallet account
❗ OpenSea.io connect redirects to the Play Store to download Metamask

Network regression:

✅ Scenario: I can remove a custom network (Palm) that was added via the popular network flow:
✅ Scenario: I can remove a custom network that was added via the custom network flow.
✅ Scenario Outline: Adding a network via a Dapp:
✅ Scenario Outline: Adding a network via the new popular network flow:
✅ Scenario: Adding a network via the custom network flow:
✅ Scenario: Adding a custom network and editing the network:
✅ Scenario: Editing a popular network
https://drive.google.com/file/d/1mFYTAzEUgc27JD4Ueyyp4SBucY-EnVxI/view?usp=sharing

Settings General View:

✅ Scenario: Changing the device language from English to Russian:
The marketing disclaimer still appears in English!!!❗❗
Scenario: Changing the app language from English to Filipino:
❗ Onboarding SRP video does not display the Filipino subtitles
https://drive.google.com/file/d/1i9YdIRA-bJhh-mpkApyOCuzRKRF2E9Fq/view?usp=drive_link
https://drive.google.com/file/d/10TJCz3sInYWCBE1Q1xw4kVO8Zi7JmJEY/view?usp=drive_link

✅Connect Wallet to Dapp or Marketplace
https://drive.google.com/file/d/1T0OdeZcDjrlWE6YP-pVoAc0z4n4ePomV/view?usp=drive_link

Onboarding custom mainnet:
The first three no longer match the new flow of the app
The app is laggy , buttons take a few clicks to respond
✅ Custom mainnet Scenario 4 (Editing a custom mainnet URL on the settings and privacy view):
✅ Custom mainnet Scenario 5 (Deleting a custom mainnet URL on the settings and privacy view)
https://drive.google.com/file/d/1nXhIUhscG8QKqfOfhd3HX22i5VxpdjbO/view?usp=sharing

QR Regression:

✅ From the in-app camera I should be able to scan a valid QR code containing an address:
✅ I should be able to use the QR scanner on the send flow to scan an address:
https://drive.google.com/file/d/11hL8sXuQh0-nJD5mJPLk1txL2NPa8Wuy/view?usp=drive_link
✅ When I scan a dapp QR code using the in-app camera I should see the appropriate warning message:
https://drive.google.com/file/d/1ZNcMrrYdLX00HRw8EaKpUBHcYuuN6_6K/view?usp=drive_link
✅ A user can scan a private key QR code using the in-app camera to import an account
✅ User scans MM Receive QR code on different network:
❗Chain ID 1 not found error when scanning Eth receive QR from another network
Other chains are recognized and the network gets switched
https://drive.google.com/file/d/1Sxzi8bbXX2l3nVQ3pNuNhapm7Mn5SIHT/view?usp=drive_link

## **Description** chore: bump version RC 3 1358 ## **Related issues** Fixes: NA ## **Manual testing steps** 1. NA 2. 3. ## **Screenshots/Recordings** NA ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

katkopel · 2024-07-02T16:31:25Z

Testing iOS v.7.26.0 (1355)

Onboarding: custom ETH mainnet
✅ Custom mainnet (Editing a custom mainnet URL on the settings and privacy view):
✅ Custom mainnet (Deleting a custom mainnet URL on the settings and privacy view):
https://drive.google.com/file/d/1qg7CYBubY6FKHFKzYzj4vxrmDDkU1xu9/view

QR Scanner Regression
✅ From the in-app camera I should be able to scan a valid QR code containing an address:
✅ I should be able to use the QR scanner on the send flow to scan an address:
https://drive.google.com/file/d/1WG27xUcSjV7yAAyO66fy3vmv7dKuyDVW/view
✅ When I scan a dapp QR code using the in-app camera I should see the appropriate warning message:
✅ When I scan a dapp QR code using the QR scanner on the send flow I should see the appropriate error message:
https://drive.google.com/file/d/1HGZfwul9ksT-vDHd-Etkyy5u9tzeNnlI/view
❌ When I scan an invalid address QR code using the in app camera I should see the appropriate warning message:
Wrong error message appears

✅ When I scan an invalid address QR code using the QR scanner on the send flow I should see the appropriate warning message:
https://drive.google.com/file/d/1cMnq4EuFRxrX9MsJh9w6PfXiJ6CQ5K7q/view
✅ A user can scan a private key QR code using the in-app camera to import an account:
✅ User scans MMM Receive QR code on different network:
❗Chain ID 1 not found error when scanning Eth receive QR from another network
https://drive.google.com/file/d/14EYuXjLQsBuanJFZpR0_3mDZLKCVVXwd/view

Setting: General view
✅ Scenario: Changing the device language from English to Russian:
❗ After selecting to import SRP, the data use checkbox disclaimer appears in English

❗ "Help us enhance your experience" pop-up appears in English

❗ In Security & Privacy > Estimate balance changes and Data collection for marketing appears in English
https://drive.google.com/file/d/1wlZncRZ2N5G_lc1QR96dkpgSLD_3kRrG/view

✅ Scenario: Changing the app language from English to Filipino:
❗ In Security & Privacy > Estimate balance changes and Data collection for marketing & MetaMetrics appears in English
https://drive.google.com/file/d/13dYc2eMVAQKXMK6cowLm4FnRmd4Hw8Hj/view

Browser Regression
✅ Scenario: Searching an invalid url and prompts the user with an error message:
✅ Scenario: Navigation with browser controls:
✅ Scenario: ENS website loads correctly:
✅ Scenario: From the browser I can successfully upload a picture:
✅ Scenario: Address bar:
✅ Scenario: Adding browser Favorites:
✅ Scenario: Browser Options Menu:
Browser back button -
Share, Network change in wallet, & New Tab -
✅ Scenario: Visiting a malicious website prompts the user with the phishing detection warning:
https://drive.google.com/file/d/1HVo43a6g8O-okgpH5Mys3joRlxskhO1P/view
✅ Connect Wallet to Dapp or Marketplace
https://drive.google.com/file/d/18-mggH7CbZG4Oaw5vHTC3d1S7j40YAPR/view

Network regression
✅ Scenario: I can remove a custom network (Palm) that was added via the popular network flow:
✅ Scenario: I can remove a custom network that was added via the custom network flow.
✅ Scenario Outline: Adding a network via a Dapp:
✅ Scenario Outline: Adding a network via the new popular network flow:
✅ Scenario: Adding a network via the custom network flow:
✅ Scenario: Adding a custom network and editing the network:
✅ Scenario: Editing a popular network:
https://drive.google.com/file/d/1wcyrGwQxNbAWFa4aNHMu_gDe7wx8stDf/view

This PR cherry picks following linked PRs: #10163 (Icon performance issue) #10227 (Fixing e2e tests caused by `useTokenListEntries`) #10219 (Fixing flaky e2e issue on `AdvancedGasComponent`) #10067 (Add smokeAssets e2e tag - This is a requirement for #10219) >[!NOTE] > these 4 PRs have to be considered as only one fix, hence the single cherry-pick --------- Co-authored-by: Curtis David <Curtis.David7@gmail.com> Co-authored-by: sahar-fehri <sahar.fehri@consensys.net>

## **Description** 7.26.0 bump 1359 rc 4 ## **Related issues** Fixes: NA ## **Manual testing steps** 1. NA 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

chrisleewilcox · 2024-07-05T19:30:27Z

QA Sign-off for platform team.

chrisleewilcox · 2024-07-05T19:30:31Z

QA Sign-off for platform team.

chrisleewilcox

LGTM

github-actions · 2024-07-05T20:06:37Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 34ff4f7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3bb4163a-14c1-4730-b437-9581a618813e

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarcloud · 2024-07-05T20:13:01Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

7.26.0

5e885ba

metamaskbot added the release-7.26.0 Issue or pull request that will be included in release 7.26.0 label Jun 20, 2024

chrisleewilcox added team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 21, 2024

chore: cherry-pick #10039 (#10059)

c5497a9

This PR cherry-picks #10039 --------- Co-authored-by: OGPoyraz <omergoktugpoyraz@gmail.com> Co-authored-by: LeoTM <1881059+leotm@users.noreply.github.com> Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>

This was referenced Jun 21, 2024

chore: cherry-pick #10039 #10059

Merged

feat: enable transaction simulations #10039

Merged

update changelog

17c7246

chore: cherry-pick #10055 (#10072)

87bc107

This PR cherry-picks #10055 Co-authored-by: SamuelSalas <samuel.salas.reyes@gmail.com>

This was referenced Jun 21, 2024

test: Fix detox test run inconsistencies #10055

Merged

chore: cherry-pick #10055 #10072

Merged

NicolasMassart and others added 2 commits June 24, 2024 12:40

chore: cherry-pick #10064 (#10107)

045fa2b

This PR cherry-picks #10064 Co-authored-by: Daniel <80175477+dan437@users.noreply.github.com>

metamaskbot mentioned this pull request Jun 25, 2024

chore: cherry-pick #10064 #10107

Merged

NicolasMassart and others added 3 commits June 25, 2024 17:25

chore: bump build for 7.26.0 - RC2 (#10105)

8a84f15

bump build number to 1355 for 7.26.0 RC2 This is for testing STX

chore: cherry-pick #10088 (#10113)

b92d42e

This PR cherry-picks #10088 Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>

chore: cherry-pick #10099 (#10114)

865de43

This PR cherry-picks #10099 Co-authored-by: infiniteflower <139582705+infiniteflower@users.noreply.github.com> Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>

This was referenced Jun 25, 2024

chore: cherry-pick #10088 #10113

Merged

fix: Swap with unapproved token #10088

Merged

chore: cherry-pick #10099 #10114

Merged

sethkfman and others added 2 commits June 25, 2024 13:18

updated bitrise file to fix E2E upgrade tests

400a5b3

chore: cherry-pick #10133 (#10140)

fa1ae88

This PR cherry-picks #10133 Co-authored-by: Mark Stacey <markjstacey@gmail.com>

This was referenced Jun 27, 2024

fix: Fix BaseControllerV1 state rehydration #10133

Merged

chore: cherry-pick #10133 #10140

Merged

sahar-fehri and others added 2 commits June 27, 2024 12:39

chore/cherry-pick-10142 (#10165)

c28cc25

This PR cherry-picks #10142

metamaskbot mentioned this pull request Jun 28, 2024

chore/cherry-pick-10142 #10165

Merged

sethkfman mentioned this pull request Jun 28, 2024

chore: changelog release automation #10172

Merged

7 tasks

metamaskbot mentioned this pull request Jul 3, 2024

chore: cherry-pick-10163-10227-10219-10067 #10217

Merged

chrisleewilcox added the QA Passed A successful QA run through has been done label Jul 5, 2024

sync with main

34ff4f7

sethkfman marked this pull request as ready for review July 5, 2024 20:02

sethkfman requested review from a team as code owners July 5, 2024 20:03

sethkfman added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 5, 2024

chrisleewilcox approved these changes Jul 5, 2024

View reviewed changes

sethkfman merged commit 9a2dc9d into main Jul 5, 2024
37 of 39 checks passed

github-actions bot locked and limited conversation to collaborators Jul 5, 2024

metamaskbot added the release-7.27.1 Issue or pull request that will be included in release 7.27.1 label Jul 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

7.26.0 #10052

7.26.0 #10052

github-actions bot commented Jun 20, 2024

github-actions bot commented Jun 21, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Jun 21, 2024

anaamolnar commented Jul 1, 2024

katkopel commented Jul 2, 2024 •

edited

Loading

chrisleewilcox commented Jul 5, 2024

chrisleewilcox commented Jul 5, 2024

chrisleewilcox left a comment

github-actions bot commented Jul 5, 2024 •

edited by metamaskbot

Loading

sonarcloud bot commented Jul 5, 2024

7.26.0 #10052

7.26.0 #10052

Conversation

github-actions bot commented Jun 20, 2024

github-actions bot commented Jun 21, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Jun 21, 2024

anaamolnar commented Jul 1, 2024

katkopel commented Jul 2, 2024 • edited Loading

chrisleewilcox commented Jul 5, 2024

chrisleewilcox commented Jul 5, 2024

chrisleewilcox left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 5, 2024 • edited by metamaskbot Loading

Bitrise

sonarcloud bot commented Jul 5, 2024

Quality Gate passed

github-actions bot commented Jun 21, 2024 •

edited by metamaskbot

Loading

katkopel commented Jul 2, 2024 •

edited

Loading

github-actions bot commented Jul 5, 2024 •

edited by metamaskbot

Loading