test: Fix detox test run inconsistencies

[SamuelSalas]

Description

Lately, some of the test are failing both locally and on Bitrise. Most of this errors are regarding some inconsistencies found on the viewHelper.js file. Steps closing onboarding modals are being call multiple times. So the best solution would be unifying all these steps in just one method, so any change to modals can be just change in one place and affect all test. As well, we need to fix some assertions parameters that are not following the correct definitions from the jsdocs and update the deprecated methods with their current implementations.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Smoke test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9129dcc3-e46d-4572-b627-9f90c3feab96
Regression Test run:

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[SamuelSalas]

Latest regression test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fe099dfd-1848-4b39-8c13-7691362fb61d

[chrisleewilcox]

LGTM

[metamaskbot]

Missing release label release-7.26.0 on PR. Adding release label release-7.26.0 on PR and removing other release labels(release-7.27.0), as PR was cherry-picked in branch 7.26.0.