-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Fix detox test run inconsistencies #10055
test: Fix detox test run inconsistencies #10055
Conversation
Quality Gate passedIssues Measures |
Latest regression test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fe099dfd-1848-4b39-8c13-7691362fb61d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Missing release label release-7.26.0 on PR. Adding release label release-7.26.0 on PR and removing other release labels(release-7.27.0), as PR was cherry-picked in branch 7.26.0. |
Description
Lately, some of the test are failing both locally and on Bitrise. Most of this errors are regarding some inconsistencies found on the viewHelper.js file. Steps closing onboarding modals are being call multiple times. So the best solution would be unifying all these steps in just one method, so any change to modals can be just change in one place and affect all test. As well, we need to fix some assertions parameters that are not following the correct definitions from the jsdocs and update the deprecated methods with their current implementations.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Smoke test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9129dcc3-e46d-4572-b627-9f90c3feab96
Regression Test run:
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist