Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Swap with unapproved token #10088

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

tommasini
Copy link
Contributor

Description

Awaiting for the result when adding a transaction before swapping for non approved tokens

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform team-swaps labels Jun 24, 2024
@tommasini tommasini requested review from a team as code owners June 24, 2024 14:54
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Jun 24, 2024

@callumelvidge
Copy link
Member

LGTM

@matthewwalsh0 matthewwalsh0 changed the title fix: Swap with unproved token fix: Swap with unapproved token Jun 24, 2024
@tommasini tommasini merged commit c77eed7 into main Jun 24, 2024
41 checks passed
@tommasini tommasini deleted the fix/approve-new-tokens-swapping branch June 24, 2024 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 24, 2024
@metamaskbot metamaskbot added release-7.27.0 Issue or pull request that will be included in release 7.27.0 release-7.26.0 Issue or pull request that will be included in release 7.26.0 and removed release-7.27.0 Issue or pull request that will be included in release 7.27.0 labels Jun 24, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-7.26.0 on PR. Adding release label release-7.26.0 on PR and removing other release labels(release-7.27.0), as PR was cherry-picked in branch 7.26.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.26.0 Issue or pull request that will be included in release 7.26.0 team-mobile-platform team-swaps
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants