-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update json-rpc-provider & json-rpc-middleware & json-rpc-filters #10098
base: main
Are you sure you want to change the base?
Conversation
test: type adjustments
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/eth-json-rpc-middleware@12.1.1, npm/eth-json-rpc-filters@4.2.2, npm/eth-json-rpc-middleware@4.3.0, npm/ethereumjs-common@1.5.2, npm/ethereumjs-tx@1.3.7, npm/level-errors@1.0.5, npm/merkle-patricia-tree@2.3.2 |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🍗!
This reverts commit def0c9d.
Bitrise✅✅✅ Commit hash: 0debc05 Note
|
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10098 +/- ##
==========================================
+ Coverage 47.24% 49.49% +2.24%
==========================================
Files 1370 1427 +57
Lines 33304 34420 +1116
Branches 3586 3801 +215
==========================================
+ Hits 15736 17035 +1299
+ Misses 16607 16323 -284
- Partials 961 1062 +101 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1060,7 +1072,7 @@ describe('getRpcMethodMiddleware', () => { | |||
method: 'personal_ecRecover', | |||
params: [helloWorldMessage], | |||
}; | |||
const expectedError = rpcErrors.internal('Missing signature parameter'); | |||
const expectedError = rpcErrors.internal('Internal JSON-RPC error.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know if there's a possibility of breaking UI since the error shown is different than what was there before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing question! There is a thread going on around this!
Did a light check on SDK and it seems to be all good ✅ |
@@ -3771,7 +3771,7 @@ | |||
resolved "https://registry.yarnpkg.com/@metamask/eslint-plugin-design-tokens/-/eslint-plugin-design-tokens-1.1.0.tgz#c9d4471f04f62bfb307aa261d11b7a674eb27961" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's not a single additive change to dependencies outside of @metamask
packages. Nothing to review in terms of supply-chain security specifically in this PR
This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions. |
Description
This PR is blocked due to breaking changes on the errors thrown to the dapps. More info in this thread
This PR includes:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Screen.Recording.2024-06-24.at.22.46.41.mov
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist