chore: Update json-rpc-provider & json-rpc-middleware & json-rpc-filters #10098

tommasini · 2024-06-24T21:50:06Z

Description

This PR is blocked due to breaking changes on the errors thrown to the dapps. More info in this thread

This PR includes:

Related issues

Fixes:

Manual testing steps

Go to in-app browser
Test connect with multiple dapps
Perform transaciton on test dapp

Screenshots/Recordings

Screen.Recording.2024-06-24.at.22.46.41.mov

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…rs@^7.0.0

test: type adjustments

github-actions · 2024-06-24T21:50:19Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-06-24T21:50:47Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/eth-json-rpc-filters@7.0.0	None	`0`	24.6 kB	lgbot
npm/@metamask/eth-json-rpc-middleware@12.1.2	network	`+4`	462 kB	metamaskbot
npm/@metamask/json-rpc-engine@9.0.0	None	`0`	188 kB	metamaskbot

🚮 Removed packages: npm/@metamask/eth-json-rpc-middleware@12.1.1, npm/eth-json-rpc-filters@4.2.2, npm/eth-json-rpc-middleware@4.3.0, npm/ethereumjs-common@1.5.2, npm/ethereumjs-tx@1.3.7, npm/level-errors@1.0.5, npm/merkle-patricia-tree@2.3.2

View full report↗︎

socket-security · 2024-06-24T21:50:50Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

MarioAslau

LGTM 🍗!

This reverts commit def0c9d.

github-actions · 2024-06-25T15:45:35Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0debc05
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f5aa28d3-d608-4e2e-a025-41dd07661ca6

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarcloud · 2024-06-25T15:55:16Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
55.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov-commenter · 2024-06-25T15:55:36Z

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.49%. Comparing base (b013c71) to head (0debc05).
Report is 122 commits behind head on main.

Files	Patch %	Lines
app/core/WalletConnect/WalletConnectV2.ts	0.00%	2 Missing ⚠️
app/core/BackgroundBridge/BackgroundBridge.js	66.66%	1 Missing ⚠️
app/core/Snaps/SnapBridge.ts	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10098      +/-   ##
==========================================
+ Coverage   47.24%   49.49%   +2.24%     
==========================================
  Files        1370     1427      +57     
  Lines       33304    34420    +1116     
  Branches     3586     3801     +215     
==========================================
+ Hits        15736    17035    +1299     
+ Misses      16607    16323     -284     
- Partials      961     1062     +101

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cal-L

LGTM

Cal-L · 2024-06-25T23:13:31Z

app/core/RPCMethods/RPCMethodMiddleware.test.ts

@@ -1060,7 +1072,7 @@ describe('getRpcMethodMiddleware', () => {
        method: 'personal_ecRecover',
        params: [helloWorldMessage],
      };
-      const expectedError = rpcErrors.internal('Missing signature parameter');
+      const expectedError = rpcErrors.internal('Internal JSON-RPC error.');


Do we know if there's a possibility of breaking UI since the error shown is different than what was there before?

Amazing question! There is a thread going on around this!

christopherferreira9 · 2024-06-26T10:54:17Z

Did a light check on SDK and it seems to be all good ✅

naugtur · 2024-06-28T08:01:31Z

yarn.lock

@@ -3771,7 +3771,7 @@
  resolved "https://registry.yarnpkg.com/@metamask/eslint-plugin-design-tokens/-/eslint-plugin-design-tokens-1.1.0.tgz#c9d4471f04f62bfb307aa261d11b7a674eb27961"


There's not a single additive change to dependencies outside of @metamask packages. Nothing to review in terms of supply-chain security specifically in this PR

github-actions · 2024-09-26T08:35:32Z

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

MarioAslau and others added 19 commits June 10, 2024 21:28

feat: use metamask ethJsonRpcMiddleware

205db8f

fix(deps): eth-json-rpc-filters@4.2.2 -> @metamask/eth-json-rpc-filte…

d927d34

…rs@^7.0.0

deps: json-rpc-engine@^6.1.0 -> @metamask/json-rpc-engine@^7.1.0

4d2c65f

Update JsonRpcRequest typings

63d560a

test: type adjustments

chainId is now hex string, not number

fbd8509

chore(test): eth_sendTransaction test type workarounds

f1e0653

fixup: console.error in test

e4e7599

fix(test): test for error cause message in RPCMethodMIddleware

4a914af

chore: update test

e1d2a04

chore: wip: add @ts-expect-error directive

0c1a8a1

Merge branch 'feat/eth-json-rpc' into json-rpc-middleware-12

69a39cc

chore: update .iyarc

e160aa5

Merge branch 'main' into json-rpc-middleware-12

98fba92

feat: downgrade from 12 to 11

242934d

Merge branch 'main' into json-rpc-middleware-12

6cfbed3

Merge branch 'main' into json-rpc-middleware-12

dfae3be

middleware to latest version

1342855

merge main and solve conflicts

cd52169

background bridge cleanup fix, bump json rpc engine to latest version

c6e47ed

tommasini requested review from a team as code owners June 24, 2024 21:50

tommasini changed the title ~~feat: Update json-rpc-provider & json-rpc-middleware & json-rpc-filters~~ chore: Update json-rpc-provider & json-rpc-middleware & json-rpc-filters Jun 24, 2024

tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 24, 2024

feat: removed unused imports

def0c9d

MarioAslau previously approved these changes Jun 25, 2024

View reviewed changes

Revert "feat: removed unused imports"

21b26c3

This reverts commit def0c9d.

MarioAslau dismissed their stale review via 21b26c3 June 25, 2024 14:53

MarioAslau and others added 2 commits June 25, 2024 15:54

feat: removed unused imports

6c61321

Merge branch 'main' into chore/provider-middleware-filters

0debc05

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 25, 2024

Cal-L approved these changes Jun 25, 2024

View reviewed changes

Cal-L reviewed Jun 25, 2024

View reviewed changes

tommasini added blocked DO-NOT-MERGE Pull requests that should not be merged labels Jun 26, 2024

tommasini marked this pull request as draft June 26, 2024 20:22

naugtur reviewed Jun 28, 2024

View reviewed changes

legobeat mentioned this pull request Jul 16, 2024

Bump eth-json-rpc-middleware from 4.3.0 to 9.0.1 #5105

Closed

legobeat mentioned this pull request Sep 24, 2024

chore: bump network controller 21.0.0 #11292

Closed

7 tasks

github-actions bot added the stale Issues that have not had activity in the last 90 days label Sep 26, 2024

legobeat removed the stale Issues that have not had activity in the last 90 days label Sep 26, 2024

legobeat mentioned this pull request Oct 22, 2024

fix: replace legacy eth-json-rpc deps #11952

Draft

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Update json-rpc-provider & json-rpc-middleware & json-rpc-filters #10098

chore: Update json-rpc-provider & json-rpc-middleware & json-rpc-filters #10098

tommasini commented Jun 24, 2024 •

edited

Loading

github-actions bot commented Jun 24, 2024

socket-security bot commented Jun 24, 2024 •

edited

Loading

socket-security bot commented Jun 24, 2024 •

edited

Loading

MarioAslau left a comment

github-actions bot commented Jun 25, 2024 •

edited by metamaskbot

Loading

sonarcloud bot commented Jun 25, 2024

codecov-commenter commented Jun 25, 2024

Cal-L left a comment

Cal-L Jun 25, 2024

tommasini Jun 26, 2024

christopherferreira9 commented Jun 26, 2024

naugtur Jun 28, 2024

github-actions bot commented Sep 26, 2024

		@@ -3771,7 +3771,7 @@
		resolved "https://registry.yarnpkg.com/@metamask/eslint-plugin-design-tokens/-/eslint-plugin-design-tokens-1.1.0.tgz#c9d4471f04f62bfb307aa261d11b7a674eb27961"

chore: Update json-rpc-provider & json-rpc-middleware & json-rpc-filters #10098

Are you sure you want to change the base?

chore: Update json-rpc-provider & json-rpc-middleware & json-rpc-filters #10098

Conversation

tommasini commented Jun 24, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jun 24, 2024

socket-security bot commented Jun 24, 2024 • edited Loading

socket-security bot commented Jun 24, 2024 • edited Loading

MarioAslau left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 25, 2024 • edited by metamaskbot Loading

Bitrise

sonarcloud bot commented Jun 25, 2024

Quality Gate passed

codecov-commenter commented Jun 25, 2024

Codecov Report

Cal-L left a comment

Choose a reason for hiding this comment

Cal-L Jun 25, 2024

Choose a reason for hiding this comment

tommasini Jun 26, 2024

Choose a reason for hiding this comment

christopherferreira9 commented Jun 26, 2024

naugtur Jun 28, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 26, 2024

tommasini commented Jun 24, 2024 •

edited

Loading

socket-security bot commented Jun 24, 2024 •

edited

Loading

socket-security bot commented Jun 24, 2024 •

edited

Loading

github-actions bot commented Jun 25, 2024 •

edited by metamaskbot

Loading