chore: update eslint v^8.44 #10865

tommasini · 2024-08-28T15:06:35Z

Description

This PR aims to update eslint to match extension version and to support the typescript version on mobile and remove this warning:

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.2.0

YOUR TYPESCRIPT VERSION: 5.4.5

There is some things that we need to do to finish this PR:

Solve new linter issues
Consider keep or not the @babel/preset-react to the babel parser config to javascript files (not needed, deepcheck flagged it as not used)
Discover why app/selectors/accountTrackerController.test.tsx was triggering an issue on eslint
Discover why we still have eslint issues here: e2e/pages/Settings/AesCryptoTestForm.ts (maybe we just need to convert it to JS since every e2e file is on JS )
Investigate if we should disable no-unused-vars for JS files since our efforts should be to transition those files to TypeScript (we didn't flag this until now, so let's keep this unused vars unchecked by the linter)
Investigate if we should we enable empty functions on test files (we shouldn't)
Remove unused dev package @metamask/eslint-config

Next steps after this PR:

Remove the patch to @metamask/typescript-eslint-config (to remove it we need to bump @metamask/typescript-eslint-config and fix the eslint issues that came with it, this will need to be addressed on other PR) Update @metamask/eslint-config-typescript to v^10 #11103
Add @metamask/eslint-config and fix the issues that came by doing it around (10248 problems (10219 errors, 29 warnings) - Add @metamask/eslint-config rule extension to eslint configuration file #11102
5203 errors and 0 warnings potentially fixable with the --fix option.)
Address warnings that are shown when running yarn lint like react/no-unstable-nested-components, jest/valid-expect and jest/no-disabled-tests - Address ESlint warnings #11100

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Screen.Recording.2024-09-06.at.12.01.00.mov

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…les fixed from eslint issues that were not being detected

github-actions · 2024-08-28T15:06:47Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…t-update

socket-security · 2024-08-28T15:08:05Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@babel/eslint-parser@7.25.1	unsafe	`0`	215 kB	nicolo-ribaudo
npm/@babel/helper-plugin-utils@7.24.8	None	`0`	114 kB	nicolo-ribaudo
npm/@babel/helper-string-parser@7.24.8	None	`0`	31.8 kB	nicolo-ribaudo
npm/@babel/helper-validator-option@7.24.8	None	`0`	11.8 kB	nicolo-ribaudo
npm/@babel/plugin-syntax-jsx@7.24.7	None	`0`	70 kB	nicolo-ribaudo
npm/@babel/plugin-transform-react-display-name@7.24.7	None	`0`	78.4 kB	nicolo-ribaudo
npm/@babel/plugin-transform-react-jsx@7.25.2	None	`0`	144 kB	nicolo-ribaudo
npm/@babel/types@7.25.4	environment	`0`	2.48 MB	nicolo-ribaudo
npm/@eslint-community/regexpp@4.11.0	None	`0`	446 kB	eslint-community-bot
npm/@eslint/eslintrc@2.1.4	filesystem, unsafe	`0`	659 kB	eslintbot
npm/@eslint/js@8.57.0	None	`0`	13.9 kB	eslintbot
npm/@humanwhocodes/config-array@0.11.14	None	`0`	55.6 kB	nzakas
npm/@humanwhocodes/module-importer@1.0.1	unsafe	`0`	21.2 kB	nzakas
npm/@humanwhocodes/object-schema@2.0.3	None	`0`	23.3 kB	nzakas
npm/@nicolo-ribaudo/eslint-scope-5-internals@5.1.1-v1	None	`0`	1.66 kB	nicolo-ribaudo
npm/@react-native/eslint-config@0.75.2	None	`0`	18.3 kB	react-native-bot
npm/@react-native/eslint-plugin@0.75.2	None	`0`	6.5 kB	react-native-bot
npm/@types/semver@7.5.8	None	`0`	23.3 kB	types
npm/@typescript-eslint/eslint-plugin@7.18.0	None	`0`	2.83 MB	jameshenry
npm/@typescript-eslint/parser@7.18.0	None	`0`	18.2 kB	jameshenry
npm/@typescript-eslint/scope-manager@7.18.0	None	`0`	618 kB	jameshenry
npm/@typescript-eslint/type-utils@7.18.0	None	`0`	109 kB	jameshenry
npm/@typescript-eslint/types@7.18.0	None	`0`	160 kB	jameshenry
npm/@typescript-eslint/typescript-estree@7.18.0	None	`0`	579 kB	jameshenry
npm/@typescript-eslint/utils@7.18.0	None	`0`	284 kB	jameshenry
npm/@typescript-eslint/visitor-keys@7.18.0	None	`0`	19.4 kB	jameshenry
npm/@ungap/structured-clone@1.2.0	None	`0`	26.2 kB	webreflection
npm/acorn@8.12.1	None	`0`	538 kB	marijn
npm/ansi-colors@1.1.0	None	`0`	22 kB	doowb
npm/eslint-config-prettier@8.10.0	None	`0`	19.9 kB	lydell
npm/eslint-plugin-ft-flow@2.0.3	None	`0`	505 kB	brianzchen
npm/eslint-plugin-jest@27.9.0	filesystem	`0`	325 kB	simenb
npm/eslint-plugin-react-hooks@4.6.2	environment	`0`	118 kB	react-bot
npm/eslint-visitor-keys@3.4.3	None	`0`	32.3 kB	eslintbot
npm/eslint@8.57.0	environment, filesystem	`0`	3.04 MB	eslintbot
npm/espree@9.6.1	None	`0`	73.6 kB	eslintbot
npm/esquery@1.6.0	None	`0`	1.04 MB	michaelficarra
npm/globby@11.1.0	filesystem	`0`	21.8 kB	sindresorhus
npm/ignore@5.3.2	None	`0`	53.6 kB	kael
npm/optionator@0.9.4	None	`0`	50.2 kB	gkz
npm/string-natural-compare@3.0.1	None	`0`	10.1 kB	nwoltman
npm/string.prototype.repeat@1.0.0	None	`0`	8.61 kB	nicolo-ribaudo
npm/ts-api-utils@1.3.0	None	`0`	828 kB	joshuakgoldberg
npm/word-wrap@1.2.5	None	`0`	11.8 kB	jonschlinkert

View full report↗︎

socket-security · 2024-08-28T15:08:08Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/string.prototype.repeat@1.0.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

…files

…ing eslint issues, add no duplicate enum values for discussion to eslint configuration

…n eslint disable next line

package.json

@ts-expect-error

## **Description** With this PR we are bumping typescript version on mobile. With this, we can remove some of @ts-expect-error that we have, and match extension version. We although create a warning when running eslint (yarn lint) ``` WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree. You may find that it works just fine, or you may not. SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.2.0 YOUR TYPESCRIPT VERSION: 5.4.5 ``` Since typescript seems to be working fine we can go with this PR to review but also means that we also need to update eslint, that is happening on this [PR](#10865), and since have more changes will be open for discussion. ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

codecov-commenter · 2024-08-30T16:27:40Z

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.75%. Comparing base (8dcdd3c) to head (fc21530).
Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
...y/components/Icons/Icon/scripts/generate-assets.js	0.00%	1 Missing ⚠️
...omponents/UI/CollectibleMedia/CollectibleMedia.tsx	0.00%	0 Missing and 1 partial ⚠️
...rmations/components/EditGasFee1559Update/index.tsx	0.00%	0 Missing and 1 partial ⚠️
app/core/MobilePortStream.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10865      +/-   ##
==========================================
- Coverage   52.75%   52.75%   -0.01%     
==========================================
  Files        1534     1540       +6     
  Lines       36777    36860      +83     
  Branches     4335     4357      +22     
==========================================
+ Hits        19403    19444      +41     
- Misses      16058    16094      +36     
- Partials     1316     1322       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

leotm · 2024-08-30T16:38:21Z

@SocketSecurity ignore npm/string.prototype.repeat@1.0.0
New Author: nicolo-ribaudo, Previous Author: mathias

github-actions · 2024-09-03T13:04:32Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b27124a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/654bc82e-5903-4985-a1d5-f41ab8db6042

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

wachunei

Ramp changes LGTM

app/core/MobilePortStream.js

app/selectors/accountTrackerControllerReRenders.test.tsx

e2e/pages/Settings/AesCryptoTestForm.js

patches/@metamask+eslint-config-typescript+9.0.1.patch

brianacnguyen

Icon changes look good. For safety, can you attach a screenshot of an Icon from either the app or storybook to make sure theyre still functioning as expected?

tommasini · 2024-09-06T11:09:12Z

@brianacnguyen Video added! Thanks for bringing it up!

github-actions · 2024-09-06T11:11:30Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: be044bd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8c120b8e-c5c0-451d-9da8-e5f49f06e9e3

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

brianacnguyen

Approved icon changes

NicolasMassart

Looks good to me.

sonarcloud · 2024-09-09T09:56:47Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
63.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

tommasini added 2 commits August 28, 2024 12:06

update typescript version to v~5.4.5

6668e21

eslint upgrade, eslintrc file updated, tsconfig file updated, some fi…

1bc1b4a

…les fixed from eslint issues that were not being detected

github-actions bot added the team-mobile-platform label Aug 28, 2024

tommasini added 2 commits August 28, 2024 16:07

Merge branch 'main' into chore/update-typescript-version-5-4-5

f011a87

Merge branch 'chore/update-typescript-version-5-4-5' into chore/eslin…

d25cbef

…t-update

tommasini mentioned this pull request Aug 28, 2024

chore: update typescript version to v~5.4.5 #10866

Merged

7 tasks

tommasini and others added 6 commits August 29, 2024 14:31

Merge branch 'main' into chore/update-typescript-version-5-4-5

55d53e0

merge chore/update-typescript-version-5-4-5

f18184c

AesCryptoTestForm to javascript file to be consistent with other e2e …

2a38b59

…files

revert unused vars on js files fix, fix tsx files with optional chain…

ebfa9a9

…ing eslint issues, add no duplicate enum values for discussion to eslint configuration

disable no unused vars for javascript files, replace no empty functio…

e89a293

…n eslint disable next line

remove unused eslint-config dev package

4f6fcb1

tommasini commented Aug 29, 2024

View reviewed changes

package.json Show resolved Hide resolved

Base automatically changed from chore/update-typescript-version-5-4-5 to main August 29, 2024 19:30

An error occurred while trying to automatically change base from chore/update-typescript-version-5-4-5 to main August 29, 2024 19:30

tommasini and others added 8 commits August 29, 2024 20:31

Merge branch 'main' into chore/eslint-update

42122dd

Merge branch 'main' into chore/eslint-update

c20eea5

yarn deduplicate

5ef6011

remove @babel/react-preset

9cf50dd

solve global variable issue on icons file

8e936b6

remove commented code on eslintrc

69a2a2c

Merge branch 'main' into chore/eslint-update

d4dea62

fix: eslint error duplicate name different file ext

fc21530

refactor: add todo for @metamask/eslint-config

53a6904

merge main

b7169ea

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Sep 3, 2024

Merge branch 'main' into chore/eslint-update

b27124a

gauthierpetetin assigned tommasini Sep 3, 2024

wachunei previously approved these changes Sep 3, 2024

View reviewed changes

tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 3, 2024

NicolasMassart reviewed Sep 3, 2024

View reviewed changes

brianacnguyen requested changes Sep 3, 2024

View reviewed changes

tommasini and others added 2 commits September 6, 2024 11:12

Merge branch 'main' into chore/eslint-update

1ffe760

address review

be044bd

tommasini dismissed wachunei’s stale review via be044bd September 6, 2024 11:04

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 6, 2024

brianacnguyen approved these changes Sep 6, 2024

View reviewed changes

abretonc7s approved these changes Sep 8, 2024

View reviewed changes

jpuri approved these changes Sep 9, 2024

View reviewed changes

Merge branch 'main' into chore/eslint-update

9ef4fba

NicolasMassart approved these changes Sep 9, 2024

View reviewed changes

tommasini merged commit 462fc33 into main Sep 9, 2024
39 checks passed

tommasini deleted the chore/eslint-update branch September 9, 2024 10:07

github-actions bot locked and limited conversation to collaborators Sep 9, 2024

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 9, 2024

metamaskbot added the release-7.32.0 Issue or pull request that will be included in release 7.32.0 label Sep 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update eslint v^8.44 #10865

chore: update eslint v^8.44 #10865

tommasini commented Aug 28, 2024 •

edited

Loading

github-actions bot commented Aug 28, 2024

socket-security bot commented Aug 28, 2024 •

edited

Loading

socket-security bot commented Aug 28, 2024 •

edited

Loading

codecov-commenter commented Aug 30, 2024

leotm commented Aug 30, 2024

github-actions bot commented Sep 3, 2024 •

edited by metamaskbot

Loading

wachunei left a comment

brianacnguyen left a comment

tommasini commented Sep 6, 2024

github-actions bot commented Sep 6, 2024 •

edited by metamaskbot

Loading

brianacnguyen left a comment

NicolasMassart left a comment

sonarcloud bot commented Sep 9, 2024

chore: update eslint v^8.44 #10865

chore: update eslint v^8.44 #10865

Conversation

tommasini commented Aug 28, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Aug 28, 2024

socket-security bot commented Aug 28, 2024 • edited Loading

socket-security bot commented Aug 28, 2024 • edited Loading

Next steps

codecov-commenter commented Aug 30, 2024

Codecov Report

leotm commented Aug 30, 2024

github-actions bot commented Sep 3, 2024 • edited by metamaskbot Loading

Bitrise

wachunei left a comment

Choose a reason for hiding this comment

brianacnguyen left a comment

Choose a reason for hiding this comment

tommasini commented Sep 6, 2024

github-actions bot commented Sep 6, 2024 • edited by metamaskbot Loading

Bitrise

brianacnguyen left a comment

Choose a reason for hiding this comment

NicolasMassart left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Sep 9, 2024

Quality Gate passed

tommasini commented Aug 28, 2024 •

edited

Loading

socket-security bot commented Aug 28, 2024 •

edited

Loading

socket-security bot commented Aug 28, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Sep 6, 2024 •

edited by metamaskbot

Loading