-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update eslint v^8.44 #10865
chore: update eslint v^8.44 #10865
Conversation
…les fixed from eslint issues that were not being detected
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
…ing eslint issues, add no duplicate enum values for discussion to eslint configuration
…n eslint disable next line
## **Description** With this PR we are bumping typescript version on mobile. With this, we can remove some of @ts-expect-error that we have, and match extension version. We although create a warning when running eslint (yarn lint) ``` WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree. You may find that it works just fine, or you may not. SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.2.0 YOUR TYPESCRIPT VERSION: 5.4.5 ``` Since typescript seems to be working fine we can go with this PR to review but also means that we also need to update eslint, that is happening on this [PR](#10865), and since have more changes will be open for discussion. ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10865 +/- ##
==========================================
- Coverage 52.75% 52.75% -0.01%
==========================================
Files 1534 1540 +6
Lines 36777 36860 +83
Branches 4335 4357 +22
==========================================
+ Hits 19403 19444 +41
- Misses 16058 16094 +36
- Partials 1316 1322 +6 ☔ View full report in Codecov by Sentry. |
@SocketSecurity ignore npm/string.prototype.repeat@1.0.0 |
Bitrise❌❌❌ Commit hash: b27124a Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ramp changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Icon changes look good. For safety, can you attach a screenshot of an Icon from either the app or storybook to make sure theyre still functioning as expected?
@brianacnguyen Video added! Thanks for bringing it up! |
Bitrise✅✅✅ Commit hash: be044bd Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved icon changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Quality Gate passedIssues Measures |
Description
This PR aims to update eslint to match extension version and to support the typescript version on mobile and remove this warning:
There is some things that we need to do to finish this PR:
Solve new linter issues
Consider keep or not the
@babel/preset-react
to the babel parser config to javascript files (not needed, deepcheck flagged it as not used)Discover why app/selectors/accountTrackerController.test.tsx was triggering an issue on eslint
Discover why we still have eslint issues here: e2e/pages/Settings/AesCryptoTestForm.ts (maybe we just need to convert it to JS since every e2e file is on JS )
Investigate if we should disable no-unused-vars for JS files since our efforts should be to transition those files to TypeScript (we didn't flag this until now, so let's keep this unused vars unchecked by the linter)
Investigate if we should we enable empty functions on test files (we shouldn't)
Remove unused dev package @metamask/eslint-config
Next steps after this PR:
5203 errors and 0 warnings potentially fixable with the --fix option.)
yarn lint
likereact/no-unstable-nested-components
,jest/valid-expect
andjest/no-disabled-tests
- Address ESlint warnings #11100Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Screen.Recording.2024-09-06.at.12.01.00.mov
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist