Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused events #11287

Merged
merged 7 commits into from
Oct 2, 2024
Merged

chore: remove unused events #11287

merged 7 commits into from
Oct 2, 2024

Conversation

NicolasMassart
Copy link
Contributor

@NicolasMassart NicolasMassart commented Sep 18, 2024

Description

Cleans app/core/Analytics/MetaMetrics.events.ts of unused events and event names.
These events are not tracked anywhere in our mobile codebase.

Related issues

fixes #11317

Manual testing steps

NA

Screenshots/Recordings

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NicolasMassart NicolasMassart added Run Smoke E2E Triggers smoke e2e on Bitrise needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 18, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.79%. Comparing base (7475ab4) to head (925fc74).
Report is 42 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11287      +/-   ##
==========================================
+ Coverage   55.24%   55.79%   +0.54%     
==========================================
  Files        1558     1583      +25     
  Lines       37153    37546     +393     
  Branches     4406     4494      +88     
==========================================
+ Hits        20527    20948     +421     
+ Misses      16155    16103      -52     
- Partials      471      495      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MetaMask MetaMask deleted a comment from github-actions bot Sep 23, 2024
@NicolasMassart NicolasMassart added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 23, 2024
Copy link
Contributor

github-actions bot commented Sep 23, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e793178
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2fc7dfbe-0588-4df7-8267-db097e056d4b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@NicolasMassart NicolasMassart requested review from a team as code owners September 24, 2024 08:28
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 30, 2024
Copy link
Contributor

github-actions bot commented Sep 30, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 99fb58a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ea243bf2-8ef8-4cac-bd1a-d8cc15adce23

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Sep 30, 2024

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicolasMassart NicolasMassart added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit f76e110 Oct 2, 2024
42 checks passed
@NicolasMassart NicolasMassart deleted the chore/10784_clean_events branch October 2, 2024 09:54
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 2, 2024
@gauthierpetetin gauthierpetetin added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

chore: clean the events list from unused events
5 participants