feat: bump network controller 21.0.0 remove feature flag #11436

salimtb · 2024-09-25T12:24:06Z

Description

This PR introduces remove the feature flag to display the new multi-rpc feature UI

Related issues

Fixes: #11232 #11233

Manual testing steps

Pull the branch and run the app.
Navigate to the migration flow.
Test that the migration modal appears and completes successfully.
Verify that the new multi-RPC and block explorer UI is fully visible and functional after migration.
Ensure the app behaves as expected with the updated configurations.

Screenshots/Recordings

Before

After

Migration.mov

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-09-25T12:24:19Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov-commenter · 2024-09-29T10:45:27Z

Codecov Report

Attention: Patch coverage is 19.44444% with 29 lines in your changes missing coverage. Please review.

Please upload report for BASE (salim/bump-network-controller-21.0.0-migration-script-and-ui@0474f3d). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...Settings/NetworksSettings/NetworkSettings/index.js	7.14%	26 Missing ⚠️
...mponents/Views/NetworkSelector/NetworkSelector.tsx	33.33%	2 Missing ⚠️
app/util/hideKeyFromUrl.ts	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@                                       Coverage Diff                                       @@
##             salim/bump-network-controller-21.0.0-migration-script-and-ui   #11436   +/-   ##
===============================================================================================
  Coverage                                                                ?   54.24%           
===============================================================================================
  Files                                                                   ?     1710           
  Lines                                                                   ?    39044           
  Branches                                                                ?     4806           
===============================================================================================
  Hits                                                                    ?    21179           
  Misses                                                                  ?    16391           
  Partials                                                                ?     1474

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-09-29T10:45:34Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: fd36957
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d4905882-03c7-4a95-9307-d5f92f54c965

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2024-09-29T14:47:10Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: aa9c5e9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/59189be5-8389-4bc2-b336-f0ecc6b693d5

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2024-09-29T16:21:44Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5acc79b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3ab16886-a8a8-4a6b-bb30-79f94234259a

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-09-30T12:18:09Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 57649cc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0cae6e0c-8bec-47f7-9d10-606432e430d3

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-10-01T12:09:04Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9fb2094
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f80a5bba-05fc-4f41-a97f-5bd8fdf6a80b

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

sonarcloud · 2024-10-11T13:59:17Z

Quality Gate failed

Failed conditions
39.9% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

salimtb · 2024-10-11T14:48:07Z

This pull request was merged into this feature branch, so I need approval on that feature branch. I'm keeping the PR open to make the review process easier.

…etworks with Distinct ChainIDs and Multiple RPC URLs (#11705)  ## **Description** This PR refactors our network configuration to eliminate the use of multiple networks with the same ChainID but different RPC URLs. Instead, we are moving towards a setup where each network is uniquely identified by a distinct ChainID and can have multiple RPC URLs associated with it. This PR includes three merge commits. The first primarily addresses the Network Controller upgrade, as outlined in issue #[11229](#11229). The second commit contains the script for migrating the state to v21, and the third commit includes all the UI changes along with the fix for the e2e tests. For more details, please refer to [this](https://github.com/orgs/MetaMask/projects/120/views/1) . related PRs: - #11292 - #11622 - #11436  ## **Related issues** Fixes: #[11229](#11229) #[11232](#11232) #[11234](#11234) #11233 ## **Manual testing steps** 1. Go to add network flow and test ## **Screenshots/Recordings**  ### **Before**  ### **After** https://drive.google.com/drive/folders/149Xji42k5of5Vl8nBlI0pFYFgPnWqILH?usp=drive_link  ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions bot added the team-assets label Sep 25, 2024

salimtb changed the base branch from main to salim/bump-network-controller-21.0.0 September 25, 2024 12:24

salimtb force-pushed the salim/bump-network-controller-21.0.0-migration branch 2 times, most recently from 13f5318 to 2e989e9 Compare September 27, 2024 15:56

salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 29, 2024

salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 29, 2024

salimtb force-pushed the salim/bump-network-controller-21.0.0-migration branch from fd36957 to aa9c5e9 Compare September 29, 2024 14:42

salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 29, 2024

salimtb force-pushed the salim/bump-network-controller-21.0.0-migration branch 2 times, most recently from 59c503c to c298a5f Compare September 30, 2024 11:24

salimtb changed the title ~~Salim/bump network controller 21.0.0 migration~~ Salim/bump network controller 21.0.0 migration Modal + remove feature flag Sep 30, 2024

salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 30, 2024

salimtb marked this pull request as ready for review October 1, 2024 12:41

salimtb requested a review from a team as a code owner October 1, 2024 12:41

salimtb force-pushed the salim/bump-network-controller-21.0.0-migration branch from a8e4ec0 to 51e5f8e Compare October 10, 2024 12:02

salimtb mentioned this pull request Oct 10, 2024

feat: Transition from Multiple Networks with Same ChainID to Unique Networks with Distinct ChainIDs and Multiple RPC URLs #11705

Merged

7 tasks

salimtb force-pushed the salim/bump-network-controller-21.0.0-migration-script-and-ui branch 2 times, most recently from bbeb779 to e3c7dc5 Compare October 10, 2024 22:35

salimtb added 16 commits October 11, 2024 00:36

fix: add migration scrippt for network controller v21

2547419

fix: new commit

3dca918

fix: increase test coverage

11a6e92

fix: fix test coverage

290d046

fix: clean up

3a82ead

fix: remove toast

e667562

fix: clean up

6ab3dff

fix: fix QA bugs

08865a3

fix: fix e2e tests

91eac87

fix: fix migration version before rebase

aed72af

fix: fix migration

799ee2b

fix: fix file system

4f41b10

fix: fix patch

8c4d949

fix: fix sonar quality

ff5c077

fix: fix add rpc button title

2b31d6d

fix: fix android input case

d874aa9

salimtb force-pushed the salim/bump-network-controller-21.0.0-migration branch from 7819195 to d874aa9 Compare October 10, 2024 22:36

salimtb added 3 commits October 11, 2024 11:48

fix: fix design ui

63c919e

fix: fix non regression tests

2d43708

fix: fix PR comments

4b1611d

salimtb marked this pull request as draft October 13, 2024 16:05

salimtb closed this Oct 14, 2024

github-actions bot locked and limited conversation to collaborators Oct 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: bump network controller 21.0.0 remove feature flag #11436

feat: bump network controller 21.0.0 remove feature flag #11436

salimtb commented Sep 25, 2024 •

edited

Loading

github-actions bot commented Sep 25, 2024

codecov-commenter commented Sep 29, 2024 •

edited

Loading

github-actions bot commented Sep 29, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Sep 29, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Sep 29, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Sep 30, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 1, 2024 •

edited by metamaskbot

Loading

sonarcloud bot commented Oct 11, 2024

salimtb commented Oct 11, 2024

feat: bump network controller 21.0.0 remove feature flag #11436

feat: bump network controller 21.0.0 remove feature flag #11436

Conversation

salimtb commented Sep 25, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 25, 2024

codecov-commenter commented Sep 29, 2024 • edited Loading

Codecov Report

github-actions bot commented Sep 29, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Sep 29, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Sep 29, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Sep 30, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Oct 1, 2024 • edited by metamaskbot Loading

Bitrise

sonarcloud bot commented Oct 11, 2024

Quality Gate failed

salimtb commented Oct 11, 2024

salimtb commented Sep 25, 2024 •

edited

Loading

codecov-commenter commented Sep 29, 2024 •

edited

Loading

github-actions bot commented Sep 29, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Sep 29, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Sep 29, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Sep 30, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 1, 2024 •

edited by metamaskbot

Loading