Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: STAKE-824: [FE] build staking input confirmation screen #11605

Merged
merged 30 commits into from
Oct 16, 2024

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Oct 3, 2024

Description

This PR adds the staking confirmation screen with some mock data being used temporarily.

Change List

  • Add staking confirmation screen.
  • Connect existing <StakeInputView /> to staking confirmation screen when user enters valid amount to stake.

Related issues

Ticket: [FE] Build staking input confirmation screen - (link)
Figma Designs - link

Manual testing steps

  1. Add export MM_POOLED_STAKING_UI_ENABLED=true to your .js.env file.
  2. Click on Ethereum In the token list page
  3. Scroll down a bit and click "Stake more". This should open the stake input view (not related to this PR)
  4. Enter a valid amount to stake and click "Confirm"
  5. You should be redirected to a staking confirmation screen. The screen should display the amount to stake in wETH and Fiat.

Screenshots/Recordings

Before

Nothing would happen after clicking "Confirm" on the stake input view. This screen is new.

After

stake-824-build-stake-confirmation-screen-after.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 marked this pull request as ready for review October 3, 2024 15:27
@Matt561 Matt561 requested review from a team as code owners October 3, 2024 15:27
@Matt561 Matt561 requested a review from amitabh94 October 3, 2024 15:27
@Matt561
Copy link
Contributor Author

Matt561 commented Oct 3, 2024

The Interacting with row on the confirmation screen has been updated as per this morning's design updates

Screenshot

image

@Matt561 Matt561 force-pushed the feat/stake-824-build-staking-input-confirmation-screen branch 2 times, most recently from 63ddf21 to a66d609 Compare October 3, 2024 16:56
…racting with section to match latest designs
amitabh94
amitabh94 previously approved these changes Oct 15, 2024
Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Matt561 Matt561 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 15, 2024
Copy link
Contributor

github-actions bot commented Oct 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ea4211b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/045374b5-202b-43c5-abc5-12a6fe28858c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@brianacnguyen brianacnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change AmountHeader to another name to reduce confusions

@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 15, 2024
Copy link
Contributor

github-actions bot commented Oct 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9379b1a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5f33197f-1501-4f97-8cdc-bf9c019f9e76

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Oct 15, 2024

@brianacnguyen
Copy link
Contributor

Approved, though I'd suggest to update the AccountHeaderCard to not include Header

@Matt561 Matt561 disabled auto-merge October 15, 2024 23:26
@Matt561 Matt561 added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit f996de1 Oct 16, 2024
43 checks passed
@Matt561 Matt561 deleted the feat/stake-824-build-staking-input-confirmation-screen branch October 16, 2024 00:20
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants