feat: Sort/Import Tokens in Mobile

[gambinish]

Description

Implements Token Sorting on mobile. This is the mobile implementation of the same feature on extension: MetaMask/metamask-extension#27184

Note that this currently includes a patch of the PreferencesController. There is a corresponding PR in core to add this to a formal controller release: MetaMask/core#4747

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-357

Manual testing steps

Go to Portfolio Screen
Sort should allow sorting by declining fiat balance by default. Users can then toggle and sort alphabetically or by declining fiat balance.

Import button should function the same as the import token link in footer

Screenshots/Recordings

Screen.Recording.2024-10-03.at.10.37.36.PM.mov

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sahar-fehri]

I think im still seeing this issue; i remember it was fixed in a previous PR?

[andreahaku]

a couple of very minor code optimisations

[salimtb]

i just tested the feature , looks great , lgtm ✅

[sahar-fehri]

I ve seen this sonar issue https://sonarcloud.io/project/issues?sinceLeakPeriod=true&issueStatuses=OPEN%2CCONFIRMED&pullRequest=11618&id=metamask-mobile&open=AZJ4jkkCJ8jX2B2IGuL8

I think its related to this signature being deprecated
trackEvent( event: IMetaMetricsEvent, properties?: CombinedProperties, saveDataRecording?: boolean, ): void;

I have seen a thread about this suggesting to use MetricsEventBuilder and non-deprecated trackEvent instead:
trackEvent(event: ITrackingEvent, saveDataRecording?: boolean): void;

[github-actions]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: f376551
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cfccaf70-e0ea-4a4c-98b8-639a6e2e7a9d

Note

• This comment will auto-update when build completes
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[gambinish]

I think im still seeing this issue; i remember it was fixed in a previous PR?

@sahar-fehri have you pulled the latest? This is what I see:

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e106631
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/70a5ec82-c3c2-4de4-87c4-e14df4c4abb2

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Cal-L]

LGTM. Only nit - The term Declining Balance along with the red highlight makes it seem like a destructive action, which is not since sorting is for display only. To keep it neutral and consistent with the other Alphabetically, I'd recommend using the word Balance followed by high to low and remove the red highlight.

[gambinish]

LGTM. Only nit - The term Declining Balance along with the red highlight makes it seem like a destructive action, which is not since sorting is for display only. To keep it neutral and consistent with the other Alphabetically, I'd recommend using the word Balance followed by high to low and remove the red highlight.

This is a good callout. I should have cut a new recording since this was addressed:

Screen.Recording.2024-10-22.at.12.02.40.PM.mov

As an aside, I have a follow up PR to update this to a BottomSheet component anyway, so should be pretty short-lived