-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: network Controller Migration + UI #11622
feat: network Controller Migration + UI #11622
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
5c89054
to
db8bf4b
Compare
db8bf4b
to
ddbccd8
Compare
Bitrise❌❌❌ Commit hash: ddbccd8 Note
Tip
|
Bitrise✅✅✅ Commit hash: 9969816 Note
|
Bitrise✅✅✅ Commit hash: 0ba4c47 Note
|
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR introduces the UI implementation for the Multi-RPC Modal, which is part of the broader initiative to support multiple RPC endpoints for networks. The modal allows users to view and select from multiple RPC options for a specific network, ensuring a smoother transition or switch between different endpoints. **UI Only: This PR focuses solely on the implementation of the UI. The modal is not yet integrated or functional in the application as it requires the upgrade of the Network Controller to version v21.** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: ## **Manual testing steps** 1. this Modal is not called yet , it's require the network controller v21 to be used 2. the use of this modal will be done on this [PR](#11622) ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <img width="438" alt="Screenshot 2024-10-04 at 11 44 15" src="https://github.com/user-attachments/assets/f558a5a8-796a-423c-b957-f7e7aee8d0b2"> <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
77ddc58
to
2f7ff1f
Compare
Bitrise✅✅✅ Commit hash: 88d8f75 Note
|
d4c52cc
to
0474f3d
Compare
Bitrise❌❌❌ Commit hash: 0474f3d Note
Tip
|
0474f3d
to
bbeb779
Compare
bbeb779
to
e3c7dc5
Compare
Quality Gate passedIssues Measures |
This pull request was merged into this feature branch, so I need approval on that feature branch. I'm keeping the PR open to make the review process easier. |
…etworks with Distinct ChainIDs and Multiple RPC URLs (#11705) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR refactors our network configuration to eliminate the use of multiple networks with the same ChainID but different RPC URLs. Instead, we are moving towards a setup where each network is uniquely identified by a distinct ChainID and can have multiple RPC URLs associated with it. This PR includes three merge commits. The first primarily addresses the Network Controller upgrade, as outlined in issue #[11229](#11229). The second commit contains the script for migrating the state to v21, and the third commit includes all the UI changes along with the fix for the e2e tests. For more details, please refer to [this](https://github.com/orgs/MetaMask/projects/120/views/1) . related PRs: - #11292 - #11622 - #11436 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: #[11229](#11229) #[11232](#11232) #[11234](#11234) #11233 ## **Manual testing steps** 1. Go to add network flow and test ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://drive.google.com/drive/folders/149Xji42k5of5Vl8nBlI0pFYFgPnWqILH?usp=drive_link <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Description
This PR migrates the network controller to handle merged networks and introduces a new modal to inform users about the network changes. The network configurations are merged, and the default RPC URL is now set to the last-used RPC endpoint for each network. This ensures network consistency and better user transparency about default network settings.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist