Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add tags to custom traces #11623

Merged
merged 39 commits into from
Oct 16, 2024
Merged

chore: Add tags to custom traces #11623

merged 39 commits into from
Oct 16, 2024
+470 −32

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Oct 4, 2024 •
edited
Loading

Description

Tags with measures, only added to engine initialisation span for now

image

app launch times pipeline:
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3492f0bf-1c24-453c-b9ff-35cf5928bd1a

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gauthierpetetin gauthierpetetin added team-tiger Tiger team (for tech debt reduction + performance improvements) area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. and removed team-mobile-platform labels Oct 9, 2024
@tommasini tommasini marked this pull request as ready for review October 14, 2024 22:33
@tommasini tommasini requested a review from a team as a code owner October 14, 2024 22:33
@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 14, 2024
@tommasini tommasini added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 15, 2024
@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: cd0386d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1e8df137-35e6-4e93-b63b-4f13158cc234

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ab262ee
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c7cf6663-f7e8-4941-9c75-0d516ca19a5a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ccceec1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e5302cbf-726a-4157-a82e-cb793d3a40e5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6e701cd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/79c9939c-9f84-47b6-90f6-a45a8ae1d06b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

MarioAslau
MarioAslau approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tommasini tommasini added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 7700dae Oct 16, 2024
45 checks passed
@tommasini tommasini deleted the chore/custom-span-sentry-tags branch October 16, 2024 14:59
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
@sethkfman sethkfman added release-7.33.0 Issue or pull request that will be included in release 7.33.0 and removed release-7.34.0 labels Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarioAslau MarioAslau MarioAslau approved these changes

Assignees

@tommasini tommasini

Labels
area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-tiger Tiger team (for tech debt reduction + performance improvements)
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tommasini @MarioAslau @gauthierpetetin @sethkfman @metamaskbot