ci: Enable Detox E2E in Release mode

[cortisiko]

Description

This PR enhances our end-to-end testing setup by enabling Detox to run on release builds. This change ensures that our tests are running in a production-like environment, which will help uncover issues that may not be visible in debug builds.
There is a noticeable performance difference while building the app in release mode. The apps in release mode take ~12 minutes to build compared to debug mode, where it takes ~17 minutes to build.

See release mode build times

See debug mode build times:

Key Changes:

• Updated build scripts to differentiate between release scripts and debug scripts
• Updated the Detox configuration to build the app in release mode while running on CI.
• Updated NFT tests to remove redundant steps
  - The Importing NFTs e2e tests were crashing only in release mode on iOS. The assets team will investigate and address in a follow up PR

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Smoke runs:

• https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/af0893da-2466-4a32-b6f4-4d0056f7be81
• https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f3ef024d-c0fe-4b58-a601-bd66c0023de0

Regression runs:

• https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c1214e8a-86a2-4e20-972b-6247af5bac8a
• https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53db98a1-bcfe-4dc4-91b3-20491d1171fd

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 57ca1ba
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f4daa8fd-2377-416c-8f4e-62120bfdd967

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[Andepande]

LG just a few questions for my own understanding

[chrisleewilcox]

LGTM

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bfd902a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/50ce5d35-f5d6-41bd-875a-3b1bf4b64c88

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud