Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Refining E2E Testing with API Mocking #11797

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

Andepande
Copy link
Member

@Andepande Andepande commented Oct 15, 2024

Description

This change enhances the mock functionality to enable multiple dynamic events to be passed through. This will evolve over time with how people use it. A corresponding document has been created in the contributors' repository.

Related issues

Fixes:
https://github.com/orgs/MetaMask/projects/60/views/3?pane=issue&itemId=81125053&issue=MetaMask%7Cmobile-planning%7C1944

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

change file structure and introduce portfinder to avoid port collisions
@Andepande Andepande changed the title test: test: Implement Structure for Mocking Endpoints in E2E Tests Oct 15, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 15, 2024
@Andepande Andepande changed the title test: Implement Structure for Mocking Endpoints in E2E Tests test: Best practices for mocking in e2e testing Oct 21, 2024
@Andepande Andepande marked this pull request as ready for review October 21, 2024 22:53
@Andepande Andepande requested a review from a team as a code owner October 21, 2024 22:53
@Andepande Andepande added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 21, 2024
Copy link
Contributor

github-actions bot commented Oct 21, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 489b7ff
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d830bfba-91dc-404d-9d33-3bf748532a5d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Andepande Andepande changed the title test: Best practices for mocking in e2e testing test: Mocking in e2e refactor Oct 21, 2024
@Andepande Andepande changed the title test: Mocking in e2e refactor test: Mocking wtih e2e refactor Oct 21, 2024
@Andepande Andepande changed the title test: Mocking wtih e2e refactor test: Mocking with e2e refactor Oct 23, 2024
@Andepande Andepande changed the title test: Mocking with e2e refactor test: Refining E2E Testing with API Mocking Oct 24, 2024
Copy link

sonarcloud bot commented Oct 24, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

2 participants