-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(js-ts): Convert app/core/Engine.test.js to TypeScript #11799
chore(js-ts): Convert app/core/Engine.test.js to TypeScript #11799
Commits on Oct 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 637d3bf - Browse repository at this point
Copy the full SHA 637d3bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for d0d6f81 - Browse repository at this point
Copy the full SHA d0d6f81View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9ee5cc - Browse repository at this point
Copy the full SHA b9ee5ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 99f28c8 - Browse repository at this point
Copy the full SHA 99f28c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09165d7 - Browse repository at this point
Copy the full SHA 09165d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b83b95a - Browse repository at this point
Copy the full SHA b83b95aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff535d1 - Browse repository at this point
Copy the full SHA ff535d1View commit details -
chore: Add support for custom network images (#11761)
## **Description** Resurrecting an older PR of mine to provide support for custom network images: #10448 ## **Related issues** Fixes: Support custom network icons on mobile. ## **Manual testing steps** 1. Add custom network (In this case Flare Mainnet or Songbird Testnet) 2. Icon should appear wherever Network Icon should appear ## **Screenshots/Recordings** https://github.com/user-attachments/assets/6ea5b310-4b6a-4b6c-9656-d892bae83fc3 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Configuration menu - View commit details
-
Copy full SHA for f9f602a - Browse repository at this point
Copy the full SHA f9f602aView commit details -
chore: Update Sentry Performance Sampling utils.js (#11805)
## **Description** This PR reduces the sampling rate by 50% Sentry Performance. We are currently using too much of our allocation. ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Configuration menu - View commit details
-
Copy full SHA for b416eac - Browse repository at this point
Copy the full SHA b416eacView commit details -
feat: 1940 Add custom traces (#11579)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> <img width="1052" alt="Screenshot 2024-10-11 at 20 29 04" src="https://github.com/user-attachments/assets/a5680804-7bc8-45c4-a27a-d790bd5f9a5d"> <img width="766" alt="Screenshot 2024-10-16 at 00 01 02" src="https://github.com/user-attachments/assets/aa4689f2-9ce0-4dc7-9b99-f24fd4db1b78"> <img width="699" alt="Screenshot 2024-10-15 at 17 57 12" src="https://github.com/user-attachments/assets/dc31684a-4dea-4f26-8b18-c5497679a0ce"> This task is for adding custom spans to track activities that happen between app start and wallet UI load. The screenshot below is an example of a trace for Wallet UI load that takes about a minute to load. During that time, we can see a large gap between app start spans and the initial http requests. The goal here is to isolate these areas and track them with custom spans. Once implemented, we can expect to see the custom spans appearing within the gap, which would inform us of the areas to optimize Issue: MetaMask/mobile-planning#1940 Technical Details * Added custom span for when the Login screen is mounted to when the login button is tapped * Added span for when the login button is tapped to when the wallet view is mounted * Added custom span for Engine initialization process * Added custom span for Store creation * Added custom span Storage rehydration * Added custom span fro Create New Wallet to Choose Password * Added custom span for Biometrics authentication ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Configuration menu - View commit details
-
Copy full SHA for 9ac1488 - Browse repository at this point
Copy the full SHA 9ac1488View commit details -
fix: persist token and phishing list (#11802)
## **Description** Persisting back again token list and phishing list. From 11KBs to 8MB to an wallet with: * 2 accounts * 7 Networks added plus Ethereum and LInea Mainnet Tokens imported by network * - Ethereum: 16 * - Linea: 6 * - Avalanche: 9 * - Binance: 10 * - Base: 1 * - Optimism: 3 * - Polygon: 3 * - Palm:0 * - ZkSync: 1 * - Arbitrum: 5 <img src="https://github.com/user-attachments/assets/a61cc6a3-44ec-4c93-b2d0-5fdc22157c64" width:200 /> App launch times e2e: 1- https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b1ae0ba0-cee8-472d-978e-17882f132740 2- https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d8fda877-0c9a-4448-a75a-cc4921551e16 3- https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/38dc5140-e18e-494c-a86a-22492554e837 ------After fixing e2e------ 1- https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/797b8317-6116-4bb5-8a12-e60a8e1b7aeb ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** Exploring app (tokens): https://github.com/user-attachments/assets/638e42de-2219-423f-a9ee-6b18ada57751 Phishing detector in app browser: https://github.com/user-attachments/assets/62f63451-fa7e-445f-b875-21155b13a8bc ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Aslau Mario-Daniel <marioaslau@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9db29fd - Browse repository at this point
Copy the full SHA 9db29fdView commit details
Commits on Oct 16, 2024
-
feat: STAKE-824: [FE] build staking input confirmation screen (#11605)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR adds the staking confirmation screen with some mock data being used temporarily. ### Change List - Add staking confirmation screen. - Connect existing `<StakeInputView />` to staking confirmation screen when user enters valid amount to stake. ## **Related issues** Ticket: [FE] Build staking input confirmation screen - ([link](https://consensyssoftware.atlassian.net/browse/STAKE-824)) Figma Designs - [link](https://www.figma.com/design/1c0Y9jDJe6p0j82jydJDcs/Mobile-Staking?node-id=2979-22435&m=dev) ## **Manual testing steps** 1. Add `export MM_POOLED_STAKING_UI_ENABLED=true` to your `.js.env` file. 2. Click on Ethereum In the token list page 3. Scroll down a bit and click "Stake more". This should open the stake input view (not related to this PR) 4. Enter a valid amount to stake and click "Confirm" 5. You should be redirected to a staking confirmation screen. The screen should display the amount to stake in `wETH` and Fiat. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> Nothing would happen after clicking "Confirm" on the stake input view. This screen is new. ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/84ea4c52-50c5-48c3-8077-2c2e8a92bf21 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Configuration menu - View commit details
-
Copy full SHA for f996de1 - Browse repository at this point
Copy the full SHA f996de1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83962a4 - Browse repository at this point
Copy the full SHA 83962a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a1bf7a - Browse repository at this point
Copy the full SHA 0a1bf7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6836b9d - Browse repository at this point
Copy the full SHA 6836b9dView commit details -
Merge branch 'origin/devin/convert-ts-app-core-Engine-test.js-5504' a…
…nd resolve conflicts in Engine.test.ts
Configuration menu - View commit details
-
Copy full SHA for b70df48 - Browse repository at this point
Copy the full SHA b70df48View commit details