Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Token Network Filter UI [Mobile] #11808

Draft
wants to merge 12 commits into
base: feat/mmassets_357-sort-import-tokens-mobile--token-sort-config--bottom-sheet
Choose a base branch
from
Draft

feat: Token Network Filter UI [Mobile] #11808

wants to merge 12 commits into from
+623 −26

Conversation

gambinish
Copy link
Contributor

Description

Introduces Token Networking filtering. This is a WIP draft.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish changed the base branch from main to feat/mmassets_357-sort-import-tokens-mobile--token-sort-config October 16, 2024 01:49
@gambinish gambinish changed the title feat: Token Network Filter UI feat: Token Network Filter UI [Extension] Oct 16, 2024
@gambinish gambinish changed the title feat: Token Network Filter UI [Extension] feat: Token Network Filter UI [Mobile] Oct 16, 2024
@gambinish
Copy link
Contributor Author

WIP recording:

Screen.Recording.2024-10-17.at.8.04.31.AM.mov

Base automatically changed from feat/mmassets_357-sort-import-tokens-mobile--token-sort-config to main October 22, 2024 19:29
@gambinish gambinish changed the base branch from main to feat/mmassets_357-sort-import-tokens-mobile--token-sort-config--bottom-sheet October 23, 2024 21:45
@gambinish gambinish added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 84ca594
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ed5081eb-6e51-4dae-95bc-3516c323d01f

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 997fc3d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/eb5a6228-89d3-4ded-bd25-815cff07eff9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
39.1% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@gambinish gambinish mentioned this pull request Oct 25, 2024
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonybur jonybur Awaiting requested review from jonybur

Assignees
No one assigned
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gambinish