-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(3481): overflow update #11823
feat(3481): overflow update #11823
Conversation
…3481-header-update-overflow
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise❌❌❌ Commit hash: 8a3c142 Note
Tip
|
…ile into feat-3481-header-update-overflow
…passed from params to accomdate for new ui changes
…ile into feat-3481-header-update-overflow
Bitrise🔄🔄🔄 Commit hash: 51fb3fc Note
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat-header-update #11823 +/- ##
=====================================================
Coverage ? 54.50%
=====================================================
Files ? 1737
Lines ? 39274
Branches ? 4866
=====================================================
Hits ? 21407
Misses ? 16377
Partials ? 1490 ☔ View full report in Codecov by Sentry. |
Bitrise❌❌❌ Commit hash: 953ba82 Note
Tip
|
…ile into feat-3481-header-update-overflow
…ile into feat-3481-header-update-overflow
Bitrise🔄🔄🔄 Commit hash: 5a64f40 Note
|
…ile into feat-3481-header-update-overflow
Bitrise❌❌❌ Commit hash: 7f1916f Note
Tip
|
Bitrise✅✅✅ Commit hash: 24ac953 Note
|
…ile into feat-3481-header-update-overflow
Bitrise🔄🔄🔄 Commit hash: e411135 Note
|
Bitrise✅✅✅ Commit hash: 17dbd02 Note
|
key: 'RevealPrivateCredential', | ||
name: 'RevealPrivateCredential', | ||
params: { | ||
credentialName: undefined, | ||
credentialName: '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help me understand the changes to this test file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It changes nothing to the tests but is needed ever since I updated the component props
type RevealPrivateCredentialRouteProp = RouteProp<
RootStackParamList,
'RevealPrivateCredential'
>;
interface IRevealPrivateCredentialProps {
navigation: any;
credentialName: string;
cancel: () => void;
route: RevealPrivateCredentialRouteProp;
}
Without those values TSLINT screeches at me
…dated reveal private cred tests and snapshots
Bitrise🔄🔄🔄 Commit hash: 13ece30 Note
|
Bitrise✅✅✅ Commit hash: bcb561c Note
|
Quality Gate passedIssues Measures |
Description
The overflow UI is being updated as part of a bigger redesign for the header
Part of this design is the removal of the
WalletAccount
component. It will no longer be used and can probably be removed. I will confirm and create a follow up PR to remove it.The
WalletAccount
component will no longer be used and can probably be removed. I will confirm and create a follow up PR. BecauseWalletAccount
is being removed, the more icon or overflow icon will be moved to theAccountSelectorList
. Here is the Figma designNOTE: This is being merged into my
feat-header-update
branch and NOTmain
Related issues
Feature: #3481
Manual testing steps
Changes to
RevealPrivateCredential
componentIt now accepts
selectedAddress
as params to accommodate for the new UI changes. If the params doesn't exist it will fallback to the the selected account that is fetched from the account controllerScreenshots/Recordings
Edit Account
Etherscan
Before
WIP
After
WIP
Pre-merge author checklist
Pre-merge reviewer checklist